ksummit.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Jiri Kosina <jikos@kernel.org>
To: "Bird, Tim" <Tim.Bird@sony.com>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>,
	 "laurent.pinchart@ideasonboard.com"
	<laurent.pinchart@ideasonboard.com>,
	 Andrew Lunn <andrew@lunn.ch>, Chris Mason <clm@meta.com>,
	 "ksummit@lists.linux.dev" <ksummit@lists.linux.dev>,
	 Dan Carpenter <dan.carpenter@linaro.org>,
	 Alexei Starovoitov <ast@kernel.org>,
	Rob Herring <robh@kernel.org>
Subject: RE: [MAINTAINERS / KERNEL SUMMIT] AI patch review tools
Date: Thu, 9 Oct 2025 00:21:43 +0200 (CEST)	[thread overview]
Message-ID: <71ss7536-3519-1p59-3450-0n399598p644@xreary.bet> (raw)
In-Reply-To: <MW5PR13MB5632FC46AD54998C4C584F91FDE1A@MW5PR13MB5632.namprd13.prod.outlook.com>

On Wed, 8 Oct 2025, Bird, Tim wrote:

> > Realistically, we can't even get some submitters to run checkpatch, so
> > I don't think the additional tag would help. 

Agreed.

> > What does help is having the 0day bot take a feed of the mailing list, 
> > select the [PATCH] tag and run checkpatch.pl as part of the tests, so 
> > someone could do the same with whatever AI acceptance tests are 
> > agreed.
> 
> There's no question that 0day automation of checkpatch.pl feedback
> has been a great thing.  I suspect that more submitters would run
> checkpatch before sending their patches, if failure to do so resulted
> in automatic rejection of the patch.  This is more of a process backbone
> issue than anything else.

Quite often the checkpatch-reported warnings are so negligible/trivial 
that it takes less energy to just (a) either take the patch as-is, or (b) 
modify it before application than to go through the whole resubmission 
round (*), so there is no incentive for the submitter to do better next 
time.

I am not saying what is right or wrong, that's just the way it (sometimes) 
is.

(*) Especially if the patch is actually a good and needed one, and you'd 
    need to keep track whether the resubmission really happened, etc.

Thanks,

-- 
Jiri Kosina
SUSE Labs


  reply	other threads:[~2025-10-08 22:21 UTC|newest]

Thread overview: 68+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-08 17:04 Chris Mason
2025-10-08 17:20 ` Konstantin Ryabitsev
2025-10-08 18:11   ` Sasha Levin
2025-10-08 18:35   ` Chris Mason
2025-10-08 17:57 ` Bart Van Assche
2025-10-08 18:04   ` Chris Mason
2025-10-08 18:14     ` Bart Van Assche
2025-10-08 18:42       ` Chris Mason
2025-10-08 21:08     ` Kees Cook
2025-10-09  1:37       ` Chris Mason
2025-10-08 18:33 ` Sasha Levin
2025-10-09  1:43   ` Chris Mason
2025-10-09 14:49     ` Paul E. McKenney
2025-10-08 19:08 ` Andrew Lunn
2025-10-08 19:28   ` Arnaldo Carvalho de Melo
2025-10-08 19:33     ` Laurent Pinchart
2025-10-08 19:39       ` Arnaldo Carvalho de Melo
2025-10-08 20:29         ` Andrew Lunn
2025-10-08 20:53           ` Mark Brown
2025-10-09  9:37         ` Laurent Pinchart
2025-10-09 12:48           ` Arnaldo Carvalho de Melo
2025-10-08 19:29   ` Laurent Pinchart
2025-10-08 19:50     ` Bird, Tim
2025-10-08 20:30       ` Sasha Levin
2025-10-09 12:32         ` Arnaldo Carvalho de Melo
2025-10-08 20:30       ` James Bottomley
2025-10-08 20:38         ` Bird, Tim
2025-10-08 22:21           ` Jiri Kosina [this message]
2025-10-09  9:14           ` Laurent Pinchart
2025-10-09 10:03             ` Chris Mason
2025-10-10  7:54               ` Laurent Pinchart
2025-10-10 11:40                 ` James Bottomley
2025-10-10 11:53                   ` Laurent Pinchart
2025-10-10 14:21                     ` Steven Rostedt
2025-10-10 14:35                   ` Bird, Tim
2025-10-09 14:30             ` Steven Rostedt
2025-10-09 14:51               ` Andrew Lunn
2025-10-09 15:05                 ` Steven Rostedt
2025-10-10  7:59                 ` Laurent Pinchart
2025-10-10 14:15                   ` Bird, Tim
2025-10-10 15:07                     ` Joe Perches
2025-10-10 16:01                       ` checkpatch encouragement improvements (was RE: [MAINTAINERS / KERNEL SUMMIT] AI patch review tools) Bird, Tim
2025-10-10 17:11                         ` Rob Herring
2025-10-10 17:33                           ` Arnaldo Carvalho de Melo
2025-10-10 19:21                           ` Joe Perches
2025-10-10 16:11                       ` [MAINTAINERS / KERNEL SUMMIT] AI patch review tools Steven Rostedt
2025-10-10 16:47                         ` Joe Perches
2025-10-10 17:42                           ` Steven Rostedt
2025-10-11 10:28                         ` Mark Brown
2025-10-09 16:31               ` Chris Mason
2025-10-09 17:19                 ` Arnaldo Carvalho de Melo
2025-10-09 17:24                   ` Arnaldo Carvalho de Melo
2025-10-09 17:31                     ` Alexei Starovoitov
2025-10-09 17:47                       ` Arnaldo Carvalho de Melo
2025-10-09 18:42                     ` Chris Mason
2025-10-09 18:56                       ` Linus Torvalds
2025-10-10 15:52                         ` Mauro Carvalho Chehab
2025-10-09 14:47             ` Bird, Tim
2025-10-09 15:11               ` Andrew Lunn
2025-10-09 17:58               ` Mark Brown
2025-10-09  1:15         ` Chris Mason
2025-10-08 20:37     ` Andrew Lunn
2025-10-09 12:40       ` Arnaldo Carvalho de Melo
2025-10-09 14:52 ` Paul E. McKenney
2025-10-10  3:08 ` Krzysztof Kozlowski
2025-10-10 14:12   ` Chris Mason
2025-10-31 16:51   ` Stephen Hemminger
2025-10-14  7:16 ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=71ss7536-3519-1p59-3450-0n399598p644@xreary.bet \
    --to=jikos@kernel.org \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=Tim.Bird@sony.com \
    --cc=andrew@lunn.ch \
    --cc=ast@kernel.org \
    --cc=clm@meta.com \
    --cc=dan.carpenter@linaro.org \
    --cc=ksummit@lists.linux.dev \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox