ksummit.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@zytor.com>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: ksummit-discuss@lists.linuxfoundation.org
Subject: Re: [Ksummit-discuss] Should we force include <linux/err.h> when compiling all .c files?
Date: Mon, 28 Jul 2014 15:53:02 -0700	[thread overview]
Message-ID: <53D6D44E.1070708@zytor.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1407282214460.2074@localhost6.localdomain6>

On 07/28/2014 01:16 PM, Julia Lawall wrote:
>>
>> We have such a clear procedure.  It involves pre-arranging with Linus
>> *before the merge window begins* to run the script in question
>> *immediately before releasing rc1*.
> 
> In this case, would it really create many conflicts?  Does the list of 
> included files change often.
> 
> If there is an optimial position for the include, it could be hard to make 
> a perfect script.
> 

In this case it probably doesn't matter much, because there is a key
difference between this and most other patchsets of this type: there is
an order that this can be done which is safe.  Specifically, add the
#include where it needs to go as a patch series, and then remove it from
the build.  If this is merged into a git tree and the resulting build
fails, it will be obvious what needs to happen, and sfr and Linus are
really good about managing that in linux-next and mainline,
respectively, so I don't even think we need to go to this "special
procedure" for this case.

	-hpa

  reply	other threads:[~2014-07-28 22:53 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-25 12:39 David Howells
2014-07-25 23:24 ` Josh Triplett
2014-07-28 18:52   ` H. Peter Anvin
2014-07-28 20:16     ` Julia Lawall
2014-07-28 22:53       ` H. Peter Anvin [this message]
2014-07-29 14:35         ` Josh Triplett
2014-07-29 15:17           ` Luck, Tony
2014-07-29 16:50             ` Hugh Dickins
2014-07-29 19:06               ` Hugh Dickins
2014-07-29 14:24     ` Josh Triplett
2014-07-30 14:30       ` H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53D6D44E.1070708@zytor.com \
    --to=hpa@zytor.com \
    --cc=julia.lawall@lip6.fr \
    --cc=ksummit-discuss@lists.linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox