From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTP id 3649F8A7 for ; Fri, 30 May 2014 02:41:41 +0000 (UTC) Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [119.145.14.66]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 8CEE91FA42 for ; Fri, 30 May 2014 02:41:39 +0000 (UTC) Message-ID: <5387EFBC.4080108@huawei.com> Date: Fri, 30 May 2014 10:41:00 +0800 From: Li Zefan MIME-Version: 1.0 To: Greg KH References: <20140528143246.GV15585@mwanda> <20140528163902.GA5099@sirena.org.uk> <1401295862.13546.109.camel@dhcp-9-2-203-236.watson.ibm.com> <20140528173553.GE5099@sirena.org.uk> <3908561D78D1C84285E8C5FCA982C28F328205B1@ORSMSX114.amr.corp.intel.com> <20140528183825.GA21477@sirena.org.uk> <5386FDAB.3010106@huawei.com> <20140529174122.GC7889@kroah.com> In-Reply-To: <20140529174122.GC7889@kroah.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Cc: "ksummit-discuss@lists.linuxfoundation.org" , James Bottomley , Mark Brown , Dan Carpenter Subject: Re: [Ksummit-discuss] [TOPIC] Encouraging more reviewers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 2014/5/30 1:41, Greg KH wrote: > On Thu, May 29, 2014 at 05:28:11PM +0800, Li Zefan wrote: >> On 2014/5/29 5:32, Thomas Gleixner wrote: >>> On Wed, 28 May 2014, Mark Brown wrote: >>> >>>> On Wed, May 28, 2014 at 05:44:41PM +0000, Luck, Tony wrote: >>>> >>>>>> There's a world of difference between thanking people for review and a >>>>>> detailed account of all the changes made in every single iteration of >>>>>> the review. >>>> >>>>> This is already covered in Documentation/SubmittingPatches. Quoting >>>>> lines 585-592 (see last sentence): >>>> >>>> Right, but Daniel is proposing lifting that above the --- and including >>>> it in git. >>> >>> What you really want is: >>> >>> Link: https://lkml.kernel.org/r/MESSAGE_ID_OF_PATCH >>> >>> It's way more useful than any of the v1-n writeups, which are most of >>> the time just a completely waste of electrons. Even if written well, >>> without the actual review context they are pretty pointless. >>> >> >> A QA asked me about kernel development process. One of his question is, >> he found some valuable information in the discussion of the patch often >> won't be added to the changelog, so providing the commit how to find >> the discussion? > > A research group has created a tool that takes a given git commit, finds > the mailing list discussion for that patch. It was posted to lkml 6 or > so months ago, you should point them at that tool if they want to do > this. > Thanks for the information! So I believe not many people know about that tool and I have to try it out to see how well it works. I think many people want to do this, and the link tag is better than an out-of-tree tool, which people just don't know about. We may also use the link tag for stable commits. So for those commits that were not backported automatically but requested specifically, people can easily find the history about why it got merged. If it were there, our previous backporting work for 3.4.x would have been eaiser.