ksummit.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Alexey Dobriyan <adobriyan@gmail.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Andy Shevchenko <andriy.shevchenko@intel.com>,
	James Bottomley <James.Bottomley@hansenpartnership.com>,
	ksummit@lists.linux.dev, Dan Williams <dan.j.williams@intel.com>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Dan Carpenter <dan.carpenter@linaro.org>
Subject: Re: Clarifying confusion of our variable placement rules caused by cleanup.h
Date: Sat, 17 Jan 2026 19:23:07 +0300	[thread overview]
Message-ID: <38d7b19f-b6ff-437b-bc88-fa2047ca556a@p183> (raw)
In-Reply-To: <20260102095029.03481f90@gandalf.local.home>

On Fri, Jan 02, 2026 at 09:50:29AM -0500, Steven Rostedt wrote:
> On Wed, 31 Dec 2025 13:17:32 +0100
> Andy Shevchenko <andriy.shevchenko@intel.com> wrote:
> 
> > > There was variation of this type of nonsense with headers (not only it has
> > > to be sorted alphabetically but by length too!)  
> > 
> > By length it indeed sounds weird, but alphabetical is the natural language
> > order everybody learnt from the daycare / school years, so it's properly
> > programmed in our deep brain. Having that allows to find easily if anything one
> > is interested in is already being included. Also it allows to avoid dup inclusions
> > (was there, fixed that for real). So, it's not bad.
> 
> Actually, I like the "by length" because its aesthetically easier on the eyes.
> 
> Alphabetically is fine, but either one helps in catching duplicate headers.

Such rules for headers are mostly harmless -- headers are supposed to be
idempotent so ordering doesn't matter. But if ordering doesn't matter
why have a rule at all?

Duplicate header are trivially caught by tooling.

But such rules aren't useful either -- I've seen that Python IDEs hide
import list by default (and probably manage it) because it is not "real"
code.

Rules for initializers can be harmful because ordering affects code
generation.

  reply	other threads:[~2026-01-17 16:22 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-18 16:39 James Bottomley
2025-11-18 17:18 ` Bart Van Assche
2025-11-18 18:38   ` Linus Torvalds
2025-11-18 19:04     ` Bart Van Assche
2025-11-18 19:14       ` Linus Torvalds
2025-11-18 20:43         ` Al Viro
2025-11-18 19:15       ` H. Peter Anvin
2025-11-18 19:11     ` H. Peter Anvin
2025-11-18 19:16       ` Linus Torvalds
2025-11-18 19:19         ` H. Peter Anvin
2025-11-18 19:17     ` Steven Rostedt
2025-11-18 19:22       ` Linus Torvalds
2025-11-18 19:56         ` Steven Rostedt
2025-11-18 20:23           ` Linus Torvalds
2025-11-18 21:05             ` Linus Torvalds
2025-11-18 20:21       ` James Bottomley
2025-11-18 20:30         ` Linus Torvalds
2025-11-18 20:51         ` Steven Rostedt
2025-11-18 21:10           ` James Bottomley
2025-11-18 22:34             ` Steven Rostedt
2025-11-18 23:32               ` James Bottomley
2025-11-18 19:23 ` H. Peter Anvin
2025-11-18 20:28   ` James Bottomley
2025-11-25 13:09 ` Jani Nikula
2025-11-25 14:25 ` Alexey Dobriyan
2025-11-25 15:32   ` Stephen Hemminger
2025-11-25 16:04   ` Steven Rostedt
2025-11-25 17:57   ` H. Peter Anvin
2025-12-31 12:17   ` Andy Shevchenko
2026-01-02 14:50     ` Steven Rostedt
2026-01-17 16:23       ` Alexey Dobriyan [this message]
2026-01-17 16:54         ` Bird, Tim
2026-01-17 23:32           ` David Laight
2026-01-18 16:04         ` Steven Rostedt
2026-01-18 19:12           ` Paul E. McKenney
2026-01-18 19:17           ` James Bottomley
2026-01-18 19:33             ` Dan Carpenter
2026-01-18 19:52               ` Joe Perches
2026-01-18 21:07             ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=38d7b19f-b6ff-437b-bc88-fa2047ca556a@p183 \
    --to=adobriyan@gmail.com \
    --cc=James.Bottomley@hansenpartnership.com \
    --cc=andriy.shevchenko@intel.com \
    --cc=dan.carpenter@linaro.org \
    --cc=dan.j.williams@intel.com \
    --cc=ksummit@lists.linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox