From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id C17371C3F for ; Tue, 2 Jul 2019 15:40:00 +0000 (UTC) Received: from mail-io1-f68.google.com (mail-io1-f68.google.com [209.85.166.68]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id A01F370D for ; Tue, 2 Jul 2019 15:39:59 +0000 (UTC) Received: by mail-io1-f68.google.com with SMTP id e5so38016112iok.4 for ; Tue, 02 Jul 2019 08:39:59 -0700 (PDT) To: James Bottomley , Thomas Gleixner References: <7b73e1b7-cc34-982d-2a9c-acf62b88da16@linuxfoundation.org> <20263.1561993564@warthog.procyon.org.uk> <1561996215.3551.49.camel@HansenPartnership.com> <1562077203.3321.2.camel@HansenPartnership.com> <1562080257.3321.19.camel@HansenPartnership.com> <1562080696.3321.21.camel@HansenPartnership.com> From: Shuah Khan Message-ID: <37eb32f3-f341-b1d8-293b-c119ae278b4f@linuxfoundation.org> Date: Tue, 2 Jul 2019 09:39:57 -0600 MIME-Version: 1.0 In-Reply-To: <1562080696.3321.21.camel@HansenPartnership.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Cc: ksummit-discuss@lists.linuxfoundation.org Subject: Re: [Ksummit-discuss] [MAINTAINERS SUMMIT] Patch version changes in commit logs? List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 7/2/19 9:18 AM, James Bottomley wrote: > On Tue, 2019-07-02 at 08:10 -0700, James Bottomley wrote: >> On Tue, 2019-07-02 at 16:49 +0200, Thomas Gleixner wrote: > [...] >>> People who use the link tag today have their homebrewn scripts to >>> add them automatically and it shouldn't be rocket science to add >>> that to git, patchwork whatever. >> >> So if we find a way of automating this globally, I'm completely >> happy. However, I would also note that whatever script does this >> could likely also be run by you after the fact to generate the back >> link, so foolproof automation also lessens the need to make this a >> mandatory commit tag. > > Just on this one, it looks like getting git to archive the msgid of the > patch commit would assist any script that goes off and tries to find > patch series and its precursors in the archives, so perhaps adding that > would be the actionable change in all of this? > Looks like two things are emerging from my original thread that aimed to get clarification on including "Patch revision information" in commit logs. 1. Judiciously including information from the "Patch revision info." in the commit log could be valuable. Don't just bloat the commit log with trivial change history. This is part of patch review process and will not require any scripting. Maybe an update to the patch submit guidelines documents. 2. Archiving msgid of the patch commit for reference. This one would require some scripting to make it easier for maintainers. There two aren't mutually exclusive and are actionable. Let's distill the thread discussion to the above two items as we discuss further. thanks, -- Shuah