From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Christoph Lameter <cl@gentwo.org>
Cc: James Bottomley <James.Bottomley@hansenpartnership.com>,
ksummit-discuss@lists.linuxfoundation.org
Subject: Re: [Ksummit-discuss] Reforming Acked-by (was Re: [TOPIC] Encouraging more reviewers)
Date: Fri, 30 May 2014 12:58:47 +0200 [thread overview]
Message-ID: <3613898.QzNNH3fhMT@avalon> (raw)
In-Reply-To: <alpine.DEB.2.10.1405291132010.12545@gentwo.org>
On Thursday 29 May 2014 11:33:15 Christoph Lameter wrote:
> On Thu, 29 May 2014, Laurent Pinchart wrote:
> > On the other hand, this can be an issue for developers and/or maintainers
> > who want to ensure that all parts of a patch have received proper review.
> > That's why I sometimes split patches that perform a simple change to
> > multiple drivers in a series with one patch per driver, and then squash
> > everything into a single patch before submitting a pull request. That
> > workflow could probably be improved.
>
> Well that in turn may lead to breakage if modifications to only some files
> are merged.
This can of course only be done when the patches don't depend on each other in
a circular way.
> If the modifications in multiple files are not depending on one another then
> they could go in as separate patches in the first place.
They could, but some maintainers prefer them not to as they find it easier to
handle this kind of change in a single patch.
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2014-05-30 10:58 UTC|newest]
Thread overview: 166+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-24 9:53 [Ksummit-discuss] [TOPIC] Encouraging more reviewers James Bottomley
2014-05-24 11:19 ` Wolfram Sang
2014-05-24 19:18 ` Guenter Roeck
2014-05-25 4:56 ` NeilBrown
2014-05-25 4:57 ` James Bottomley
2014-05-26 15:41 ` Guenter Roeck
2014-05-30 16:05 ` mark gross
2014-05-30 16:45 ` Guenter Roeck
2014-06-01 14:05 ` Wolfram Sang
2014-05-25 8:59 ` Wolfram Sang
2014-05-26 12:23 ` Rafael J. Wysocki
2014-05-26 12:52 ` Wolfram Sang
2014-05-27 17:27 ` Lukáš Czerner
2014-05-27 22:57 ` Rafael J. Wysocki
2014-05-27 22:43 ` Andy Lutomirski
2014-05-27 23:09 ` Rafael J. Wysocki
2014-05-28 14:26 ` Daniel Vetter
2014-05-28 14:32 ` Dan Carpenter
2014-05-28 14:39 ` Daniel Vetter
2014-05-28 16:39 ` Mark Brown
2014-05-28 16:51 ` Mimi Zohar
2014-05-28 17:35 ` Mark Brown
2014-05-28 17:44 ` Luck, Tony
2014-05-28 18:38 ` Mark Brown
2014-05-28 21:32 ` Thomas Gleixner
2014-05-29 9:28 ` Li Zefan
2014-05-29 17:41 ` Greg KH
2014-05-30 2:41 ` Li Zefan
2014-05-30 17:28 ` Paul E. McKenney
2014-05-30 23:40 ` Greg KH
2014-05-31 16:49 ` Geert Uytterhoeven
2014-06-01 8:36 ` Takashi Iwai
2014-05-31 23:30 ` Randy Dunlap
2014-05-29 18:43 ` Steven Rostedt
2014-05-28 22:48 ` Daniel Vetter
2014-05-28 23:17 ` Laurent Pinchart
2014-05-29 18:45 ` Steven Rostedt
2014-05-29 7:35 ` Dan Carpenter
2014-05-28 16:05 ` Guenter Roeck
2014-05-28 16:37 ` Mimi Zohar
2014-05-28 16:50 ` Guenter Roeck
2014-05-28 16:20 ` Mimi Zohar
2014-05-28 16:28 ` Josh Triplett
2014-05-28 17:05 ` Jonathan Corbet
2014-05-28 21:59 ` Thomas Gleixner
2014-05-28 23:31 ` josh
2014-05-28 23:55 ` Thomas Gleixner
2014-05-29 0:39 ` Mimi Zohar
2014-05-29 0:47 ` Randy Dunlap
2014-05-29 0:52 ` Mimi Zohar
2014-05-29 6:13 ` James Bottomley
2014-05-29 18:58 ` Steven Rostedt
2014-05-29 23:34 ` Greg KH
2014-05-30 2:23 ` Li Zefan
2014-05-30 4:26 ` James Bottomley
2014-05-30 5:02 ` Greg KH
2014-05-30 5:33 ` James Bottomley
2014-05-30 14:14 ` John W. Linville
2014-05-30 16:40 ` Theodore Ts'o
2014-05-30 16:43 ` Theodore Ts'o
2014-05-30 16:56 ` [Ksummit-discuss] More productive uses of enthusiastic new kernel developers (was: Re: [TOPIC] Encouraging more reviewers) Theodore Ts'o
2014-05-30 19:54 ` Shuah Khan
2014-06-02 12:00 ` Jason Cooper
2014-05-30 20:50 ` David Woodhouse
2014-05-31 1:44 ` [Ksummit-discuss] More productive uses of enthusiastic new kernel developers Li Zefan
2014-05-31 1:54 ` Guenter Roeck
2014-05-31 2:21 ` Theodore Ts'o
2014-05-31 22:53 ` Rafael J. Wysocki
2014-05-31 2:07 ` Theodore Ts'o
2014-05-31 3:52 ` Greg KH
2014-05-31 4:08 ` Guenter Roeck
2014-05-30 23:47 ` [Ksummit-discuss] [TOPIC] Encouraging more reviewers Greg KH
2014-05-30 11:17 ` Dan Carpenter
2014-05-31 21:05 ` Dan Carpenter
2014-05-29 10:31 ` Daniel Vetter
2014-05-29 18:36 ` Greg KH
2014-05-29 15:32 ` Luck, Tony
2014-05-28 5:37 ` Wolfram Sang
2014-05-28 10:06 ` Lukáš Czerner
2014-05-28 13:57 ` Wolfram Sang
2014-05-24 14:24 ` Dan Williams
2014-05-26 12:31 ` Rafael J. Wysocki
2014-05-24 15:50 ` Trond Myklebust
2014-05-24 17:31 ` James Bottomley
2014-05-25 4:15 ` Bjorn Helgaas
2014-05-26 12:38 ` Rafael J. Wysocki
2014-05-27 18:21 ` H. Peter Anvin
2014-05-25 4:17 ` Stephen Rothwell
2014-05-25 8:53 ` Geert Uytterhoeven
2014-05-25 9:11 ` Stephen Rothwell
2014-05-27 8:16 ` Li Zefan
2014-05-25 9:09 ` Wolfram Sang
2014-05-25 22:29 ` Dan Carpenter
2014-05-26 15:53 ` James Bottomley
2014-05-27 14:39 ` Jiri Kosina
2014-05-27 20:53 ` James Bottomley
2014-05-27 21:22 ` Jiri Kosina
2014-05-28 0:10 ` Martin K. Petersen
2014-05-28 0:30 ` Greg KH
2014-05-28 23:25 ` Dan Williams
2014-05-28 23:32 ` Jiri Kosina
2014-05-28 23:47 ` Dan Williams
2014-05-29 4:01 ` Martin K. Petersen
2014-05-29 5:17 ` Dan Williams
2014-05-29 23:56 ` Martin K. Petersen
2014-05-29 23:59 ` Dan Williams
2014-05-28 23:33 ` Rafael J. Wysocki
2014-05-29 0:35 ` Ben Hutchings
2014-05-29 4:36 ` Martin K. Petersen
2014-05-29 16:46 ` Mark Brown
2014-05-29 21:57 ` Frank Rowand
2014-05-29 23:12 ` Mark Brown
2014-05-28 1:10 ` NeilBrown
2014-05-28 5:11 ` James Bottomley
2014-05-26 12:17 ` Rafael J. Wysocki
2014-05-28 18:47 ` Paul Walmsley
2014-05-28 20:15 ` josh
2014-05-29 2:15 ` Rob Herring
2014-05-29 3:34 ` Olof Johansson
2014-05-30 0:52 ` Paul Walmsley
2014-05-29 8:39 ` Jonathan Cameron
2014-05-30 0:47 ` Paul Walmsley
2014-05-30 0:51 ` Paul Walmsley
2014-05-28 18:48 ` [Ksummit-discuss] Reforming Acked-by (was Re: [TOPIC] Encouraging more reviewers) Paul Walmsley
2014-05-28 19:11 ` Mimi Zohar
2014-05-28 19:15 ` John W. Linville
2014-05-28 19:51 ` Mimi Zohar
2014-05-30 14:59 ` Steven Rostedt
2014-05-30 15:10 ` John W. Linville
2014-05-30 21:10 ` James Bottomley
2014-05-30 21:30 ` Steven Rostedt
2014-06-02 2:43 ` Randy Dunlap
2014-06-02 2:53 ` NeilBrown
2014-06-02 3:01 ` Randy Dunlap
2014-05-28 19:49 ` Guenter Roeck
2014-05-28 20:12 ` josh
2014-05-28 20:22 ` Dmitry Torokhov
2014-05-28 23:02 ` Laurent Pinchart
2014-05-28 23:18 ` Dmitry Torokhov
2014-05-28 23:29 ` Laurent Pinchart
2014-05-29 14:44 ` Christoph Lameter
2014-05-29 14:59 ` Laurent Pinchart
2014-05-29 16:33 ` Christoph Lameter
2014-05-30 10:58 ` Laurent Pinchart [this message]
2014-05-29 15:58 ` H. Peter Anvin
2014-05-29 18:27 ` Theodore Ts'o
2014-05-29 21:03 ` Rafael J. Wysocki
2014-05-29 21:03 ` Olof Johansson
2014-05-29 23:30 ` Greg KH
2014-05-30 1:12 ` Paul Walmsley
2014-05-30 5:04 ` Greg KH
2014-05-30 5:39 ` James Bottomley
2014-05-30 11:30 ` Daniel Vetter
2014-05-30 23:39 ` Greg KH
2014-05-30 10:08 ` Lukáš Czerner
2014-05-30 13:07 ` Jan Kara
2014-05-30 13:41 ` Lukáš Czerner
2014-05-30 15:22 ` Steven Rostedt
2014-05-31 1:30 ` Li Zefan
2014-05-30 14:34 ` John W. Linville
2014-05-30 0:55 ` Paul Walmsley
2014-05-30 15:17 ` Steven Rostedt
2014-05-30 15:06 ` Steven Rostedt
2014-05-30 21:26 ` Rafael J. Wysocki
2014-05-30 21:29 ` Steven Rostedt
2014-05-30 22:16 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3613898.QzNNH3fhMT@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=cl@gentwo.org \
--cc=ksummit-discuss@lists.linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox