From: Mark Brown <broonie@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Jiri Kosina <jikos@kernel.org>, ksummit@lists.linux.dev
Subject: Re: [MAINTAINERS SUMMIT] Merge tree too flat?
Date: Wed, 5 Jun 2024 12:31:13 +0100 [thread overview]
Message-ID: <356ad539-3b37-4ada-8344-45ed938c02c5@sirena.org.uk> (raw)
In-Reply-To: <20240604184506.007c4682@gandalf.local.home>
[-- Attachment #1: Type: text/plain, Size: 1264 bytes --]
On Tue, Jun 04, 2024 at 06:45:06PM -0400, Steven Rostedt wrote:
> Jiri Kosina <jikos@kernel.org> wrote:
> > Right; that's exactly how it should be done in my view.
> > But if Daniel's tree has always fed into yours (no matter whether the 'git
> > merge' way or 'apply patch' way), in doesn't really decrease the net
> > effort one level above.
> I disagree. I use to take his patches and pull them in. But having him do
> it, and also write the pull request, makes my job so much easier.
> Note, I review his work, but not some much as if I were to review his
> patches. I look at it at a different level when it's a pull request. I
> trust Daniel enough to not go through his work with a fine comb, but
> instead just look to make sure the general idea is sound.
I don't think the mechanics of how patches get moved about has a huge
impact on the effort involved - trust and delegation make much more of
a difference. I've got several areas where other people are reviewing
large volumes of patches before I ever see them, those take me almost no
time compared to what comes to me directly because of the level of trust
I place in these reviewers. These differences aren't really obvious in
the git history but they're very real.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2024-06-05 11:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-04 22:03 Jiri Kosina
2024-06-04 22:21 ` Steven Rostedt
2024-06-04 22:34 ` Jiri Kosina
2024-06-04 22:45 ` Steven Rostedt
2024-06-05 11:31 ` Mark Brown [this message]
2024-06-14 9:15 ` Wolfram Sang
2024-06-04 22:33 ` Sasha Levin
2024-06-04 22:38 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=356ad539-3b37-4ada-8344-45ed938c02c5@sirena.org.uk \
--to=broonie@kernel.org \
--cc=jikos@kernel.org \
--cc=ksummit@lists.linux.dev \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox