ksummit.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: David Howells <dhowells@redhat.com>
To: John Stultz <john.stultz@linaro.org>
Cc: ksummit-discuss@lists.linuxfoundation.org
Subject: Re: [Ksummit-discuss] Leap second handling
Date: Thu, 17 Dec 2015 00:32:05 +0000	[thread overview]
Message-ID: <30286.1450312325@warthog.procyon.org.uk> (raw)
In-Reply-To: <CALAqxLUxXSDCt+LVdiqpgY2zw0zxRP3zB+mR1xCaEE8hgWaGCg@mail.gmail.com>

John Stultz <john.stultz@linaro.org> wrote:

> As for how to treat the certs, you're option #1 "Treat it as hh:mm:59" is
> probably the closest to what the kernel does, since it repeats the 59th
> second on the leapsecond.

mktime64() appears to treat hh:mm:60 as the equivalent of the 0th second of
the next minute simply by adding the seconds on last with no checking.

I'm okay with implementing #1 or #2 for now (ie. treating as :59 of this
minute or :00 of the next minute) with a comment in the code indicating that
this is what we're doing.

Should I have mktime64() handle it or should I handle it in my X.509 code
though?  I favour the former as it's then a general solution that can be
handled in a single place.  I could put the handling of 24:00:00 being
equivalent of 00:00:00 of the next day there also.

David

  parent reply	other threads:[~2015-12-17  0:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-15 11:33 David Howells
2015-12-15 12:12 ` Arnd Bergmann
2015-12-15 14:15   ` Alexandre Belloni
2015-12-16  5:12     ` John Stultz
2015-12-17  0:32     ` David Howells [this message]
2015-12-17  0:44       ` John Stultz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=30286.1450312325@warthog.procyon.org.uk \
    --to=dhowells@redhat.com \
    --cc=john.stultz@linaro.org \
    --cc=ksummit-discuss@lists.linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox