[Ksummit-discuss] Should we force include <linux/err.h> when compiling all .c files?

[David Howells <dhowells@redhat.com>]

Should we forcibly include <linux/err.h> from the gcc command line when
compiling all .c files?  Note:

	warthog>git grep -l '#.*include.*<linux/err[.]h>' -- \*.c | wc -l
	1797

vs:

	warthog>git grep -l 'IS_ERR\|ERR_PTR\|PTR_ERR\|ERR_CAST' -- \*.c | wc -l
	4472

So a lot fewer .c files include it than use it, but according to:

	1: If you use a facility then #include the file that defines/declares
	   that facility.  Don't depend on other header files pulling in ones
	   that you use.

as pointed out to me by Stephen, it shouldn't be assumed that it's available.


However, passing errors in pointers is so very common within the kernel, it
might worth be adding linux/err.h to the automatically included stuff.

David