ksummit.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Chris Mason <clm@meta.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	"Bird, Tim" <Tim.Bird@sony.com>,
	James Bottomley <James.Bottomley@hansenpartnership.com>,
	Andrew Lunn <andrew@lunn.ch>,
	"ksummit@lists.linux.dev" <ksummit@lists.linux.dev>,
	Dan Carpenter <dan.carpenter@linaro.org>,
	Alexei Starovoitov <ast@kernel.org>,
	Rob Herring <robh@kernel.org>
Subject: Re: [MAINTAINERS / KERNEL SUMMIT] AI patch review tools
Date: Fri, 10 Oct 2025 16:52:59 +0100	[thread overview]
Message-ID: <20251010165259.36fd0416@sal.lan> (raw)
In-Reply-To: <CAHk-=wj3fQVEcAqy82JnrX2KKi4NjnEGGSH2Pf_ztnLCcveWkQ@mail.gmail.com>

Em Thu, 9 Oct 2025 11:56:23 -0700
Linus Torvalds <torvalds@linux-foundation.org> escreveu:

> On Thu, 9 Oct 2025 at 11:43, Chris Mason <clm@meta.com> wrote:
> >
> > I think it's also important to remember that AI is sometimes wildly
> > wrong.  Having the reviews show up on a list where more established
> > developers can call bullshit definitely helps protect against wasting
> > people's time.  
> 
> I really want any AI effort to be primarily geared towards
> maintainers, not end developers.
> 
> And this is a large part of the reason. I think we've all seen the
> garbage end of AI, and how it can generate more work rather than less.
> 
> We see the downsides on the security list where people use AI to
> generate questionable reports, we see it in various general bug
> handling, and we've seen it on the infrastructure where the AI tools
> cause huge issues.

I recently read an article about LLM Needle-In-a-Haystack issues
with current models(*). The problem is that, even when they do support
big input tokens (with is proportional to the number of statements at
the program code), current AI models usually loses needles (for instance 
a bad code) when the context is bigger than just a small percentage
of the maximum context(*).

(*) I didn't save the link of the article I read, but this one
    https://arxiv.org/html/2406.10149v2 is somewhat similar.
    Basically, even when the model supports large contexts,
    the probability of losing a needle in a stack increases
    with the input size in a way that, even a relatively small
    input can cause false negatives. See this comment at figure
    1:

    "GPT-4 effectively uses only about 10% of the full 128K window."

So, yeah, if one uses AI to review patches, there is a high risk
of mistakes, meaning a maintainer or an experienced developer is needed 
to review "AI reviews".

> Fairly recently Jens gave up maintaining his own git server just
> because of the horror that is AI scraping tools.

This is a different issue. I needed solve such issues on linuxTV.org 
as well. The problem there doesn't seem due to someone giving AI some
prompt, but, instead, due to bad automation used by LLM training
that behaves like a DDoS attack, trying to retrieve all possible
existing and previously-existing pages continuously, using
multiple connections and from different ip addresses.
> 
> Yes, that scraping issue a "secondary" kind of "more work rather than
> less", but it's very much a real issue nonetheless. Just the
> infrastructure load is a real thing.
> 
> Some long term goal may well be to help end developers, but I really
> think it should not be seen as any kind of primary goal for now and
> shouldn't even be on anybody's radar as a design issue.
> 
> Exactly because I think we need that "established developers can call
> bullshit" without being overwhelmed by said BS from external sources.
> 
> So I think that only once any AI tools are actively helping
> maintainers in a day-to-day workflow should people even *look* at
> having non-maintainers use them.

For bug reviews, agreed. AI can still be helpful for developers to
do things like writing unit tests and more trivial tasks, provided
that will be reviewed/fixed by the develper using such tools.
> 
> And I say that as somebody who does think it's going to be a big help.
> I know there are lots of less optimistic people around.
> 
>              Linus
> 

  reply	other threads:[~2025-10-10 15:53 UTC|newest]

Thread overview: 68+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-08 17:04 Chris Mason
2025-10-08 17:20 ` Konstantin Ryabitsev
2025-10-08 18:11   ` Sasha Levin
2025-10-08 18:35   ` Chris Mason
2025-10-08 17:57 ` Bart Van Assche
2025-10-08 18:04   ` Chris Mason
2025-10-08 18:14     ` Bart Van Assche
2025-10-08 18:42       ` Chris Mason
2025-10-08 21:08     ` Kees Cook
2025-10-09  1:37       ` Chris Mason
2025-10-08 18:33 ` Sasha Levin
2025-10-09  1:43   ` Chris Mason
2025-10-09 14:49     ` Paul E. McKenney
2025-10-08 19:08 ` Andrew Lunn
2025-10-08 19:28   ` Arnaldo Carvalho de Melo
2025-10-08 19:33     ` Laurent Pinchart
2025-10-08 19:39       ` Arnaldo Carvalho de Melo
2025-10-08 20:29         ` Andrew Lunn
2025-10-08 20:53           ` Mark Brown
2025-10-09  9:37         ` Laurent Pinchart
2025-10-09 12:48           ` Arnaldo Carvalho de Melo
2025-10-08 19:29   ` Laurent Pinchart
2025-10-08 19:50     ` Bird, Tim
2025-10-08 20:30       ` Sasha Levin
2025-10-09 12:32         ` Arnaldo Carvalho de Melo
2025-10-08 20:30       ` James Bottomley
2025-10-08 20:38         ` Bird, Tim
2025-10-08 22:21           ` Jiri Kosina
2025-10-09  9:14           ` Laurent Pinchart
2025-10-09 10:03             ` Chris Mason
2025-10-10  7:54               ` Laurent Pinchart
2025-10-10 11:40                 ` James Bottomley
2025-10-10 11:53                   ` Laurent Pinchart
2025-10-10 14:21                     ` Steven Rostedt
2025-10-10 14:35                   ` Bird, Tim
2025-10-09 14:30             ` Steven Rostedt
2025-10-09 14:51               ` Andrew Lunn
2025-10-09 15:05                 ` Steven Rostedt
2025-10-10  7:59                 ` Laurent Pinchart
2025-10-10 14:15                   ` Bird, Tim
2025-10-10 15:07                     ` Joe Perches
2025-10-10 16:01                       ` checkpatch encouragement improvements (was RE: [MAINTAINERS / KERNEL SUMMIT] AI patch review tools) Bird, Tim
2025-10-10 17:11                         ` Rob Herring
2025-10-10 17:33                           ` Arnaldo Carvalho de Melo
2025-10-10 19:21                           ` Joe Perches
2025-10-10 16:11                       ` [MAINTAINERS / KERNEL SUMMIT] AI patch review tools Steven Rostedt
2025-10-10 16:47                         ` Joe Perches
2025-10-10 17:42                           ` Steven Rostedt
2025-10-11 10:28                         ` Mark Brown
2025-10-09 16:31               ` Chris Mason
2025-10-09 17:19                 ` Arnaldo Carvalho de Melo
2025-10-09 17:24                   ` Arnaldo Carvalho de Melo
2025-10-09 17:31                     ` Alexei Starovoitov
2025-10-09 17:47                       ` Arnaldo Carvalho de Melo
2025-10-09 18:42                     ` Chris Mason
2025-10-09 18:56                       ` Linus Torvalds
2025-10-10 15:52                         ` Mauro Carvalho Chehab [this message]
2025-10-09 14:47             ` Bird, Tim
2025-10-09 15:11               ` Andrew Lunn
2025-10-09 17:58               ` Mark Brown
2025-10-09  1:15         ` Chris Mason
2025-10-08 20:37     ` Andrew Lunn
2025-10-09 12:40       ` Arnaldo Carvalho de Melo
2025-10-09 14:52 ` Paul E. McKenney
2025-10-10  3:08 ` Krzysztof Kozlowski
2025-10-10 14:12   ` Chris Mason
2025-10-31 16:51   ` Stephen Hemminger
2025-10-14  7:16 ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251010165259.36fd0416@sal.lan \
    --to=mchehab+huawei@kernel.org \
    --cc=James.Bottomley@hansenpartnership.com \
    --cc=Tim.Bird@sony.com \
    --cc=acme@kernel.org \
    --cc=andrew@lunn.ch \
    --cc=ast@kernel.org \
    --cc=clm@meta.com \
    --cc=dan.carpenter@linaro.org \
    --cc=ksummit@lists.linux.dev \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=robh@kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox