From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Kees Cook <kees@kernel.org>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Jiri Kosina <jkosina@suse.com>,
ksummit@lists.linux.dev
Subject: Re: [MAINTAINERS SUMMIT] Annotating patches containing AI-assisted code
Date: Wed, 17 Sep 2025 20:02:50 +0300 [thread overview]
Message-ID: <20250917170250.GB10145@pendragon.ideasonboard.com> (raw)
In-Reply-To: <202509161626.AA26A66@keescook>
On Tue, Sep 16, 2025 at 04:30:30PM -0700, Kees Cook wrote:
> On Tue, Sep 16, 2025 at 10:20:22AM -0400, Steven Rostedt wrote:
> > On Mon, 15 Sep 2025 11:01:46 -0700 Kees Cook wrote:
> >
> > > So, what I mean to say is it's certainly useful to declare "I used a
> > > chisel", but that for long running sessions it becomes kind of pointless
> > > to include much more than a general gist of what the process was. This
> > > immediately gets at the "trust" part of this thread making the mentioned
> > > "human understanding the generated code" a central issue. How should that
> > > be expressed? Our existing commit logs don't do a lot of "show your work"
> > > right now, but rather focus on the why/what of a change, and less "how did
> > > I write this". It's not strictly absent (some commit logs discuss what
> > > alternatives were tried and eliminated, for example), but we've tended
> > > to look only at final results and instead use trust in contributors as
> > > a stand-in for "prove to me you understand what you've changed".
> >
> > I don't think anyone cares if you used AI to help you understand the
> > situation or to test your work. But if you had a robot build you the fish
> > and you handed that in as your own work, that would be deceptive.
>
> Right, but the LLMs aren't used strictly as a "workflow" assistant. Do
> we want to say "I used the chisel to remove a big hunk of wood you can't
> see at all in the fish."
>
> Perhaps the issue is to just over-explain when the LLM is in use for
> now, and we (as a developer community) will collectively figure out what
> turns out to be unimportant or redundant over time. But this can't be
> done with a trailer tag: we're going to need relatively verbose notes
> in the commit log.
This conversation has gone in many directions, it seems to be time to
try and refocus. One way to do so would be to focus on *why* we want
those annotations. That may help then deciding how to best annotate
patches to reach the intended goals.
Personally, I care about knowing the possible LLM origin of a patch for
two main reasons:
- From a maintainer point of view, to focus my reviews. I will look for
different error patterns, or will interpret patterns differently for a
human author compared to an LLM.
This mostly focusses on code produced by LLMs. Usage of LLMs to
understand an API or review a piece of code before submission is less
of a concern.
I don't specifically need a commit trailer for this purpose, a
free-formed explanation in the commit message would be enough. I would
rely on trust that submitters will be honest there, the same way we
rely on trust that a submitter has no malicious or selfish intent in
general. We of course stay alert to detect breaches of that trust
today, and I wouldn't see a need to change the process there: we
already deal with situations where a submitter is determined not to be
trustworthy.
- From a legal point of view, to detect code that may not be compatible
with the GPL license. This is still a legal grey area, if we want to
accept code generated by LLMs without waiting for courts around the
world to make clear decisions, we can't ignore that there's a legal
risk.
For this purpose, a commit trailer would be useful, in order to easily
list affected commits.
--
Regards,
Laurent Pinchart
prev parent reply other threads:[~2025-09-17 17:03 UTC|newest]
Thread overview: 97+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-05 15:38 Jiri Kosina
2025-08-05 17:50 ` Sasha Levin
2025-08-05 18:00 ` Laurent Pinchart
2025-08-05 18:16 ` Sasha Levin
2025-08-05 21:53 ` Jiri Kosina
2025-08-05 22:41 ` Laurent Pinchart
2025-08-05 18:34 ` Lorenzo Stoakes
2025-08-05 22:06 ` Alexandre Belloni
2025-08-05 18:32 ` Lorenzo Stoakes
2025-08-08 8:31 ` Krzysztof Kozlowski
2025-08-11 21:46 ` Paul E. McKenney
2025-08-11 21:57 ` Luck, Tony
2025-08-11 22:12 ` Paul E. McKenney
2025-08-11 22:45 ` H. Peter Anvin
2025-08-11 22:52 ` Paul E. McKenney
2025-08-11 22:54 ` Jonathan Corbet
2025-08-11 23:03 ` Paul E. McKenney
2025-08-12 15:47 ` Steven Rostedt
2025-08-12 16:06 ` Paul E. McKenney
2025-08-11 22:28 ` Sasha Levin
2025-08-12 15:49 ` Steven Rostedt
2025-08-12 16:03 ` Krzysztof Kozlowski
2025-08-12 16:12 ` Paul E. McKenney
2025-08-12 16:17 ` Krzysztof Kozlowski
2025-08-12 17:12 ` Steven Rostedt
2025-08-12 17:39 ` Paul E. McKenney
2025-08-11 22:11 ` Luis Chamberlain
2025-08-11 22:51 ` Paul E. McKenney
2025-08-11 23:22 ` Luis Chamberlain
2025-08-11 23:42 ` Paul E. McKenney
2025-08-12 0:02 ` Luis Chamberlain
2025-08-12 2:49 ` Paul E. McKenney
2025-08-18 21:41 ` Mauro Carvalho Chehab
2025-08-20 21:48 ` Paul E. McKenney
2025-08-12 16:01 ` Steven Rostedt
2025-08-12 16:22 ` Paul E. McKenney
2025-08-18 21:23 ` Mauro Carvalho Chehab
2025-08-19 15:25 ` Paul E. McKenney
2025-08-19 16:27 ` Mauro Carvalho Chehab
2025-08-20 22:03 ` Paul E. McKenney
2025-08-21 10:54 ` Miguel Ojeda
2025-08-21 11:46 ` Mauro Carvalho Chehab
2025-08-12 8:38 ` James Bottomley
2025-08-12 13:15 ` Bird, Tim
2025-08-12 14:31 ` Greg KH
2025-08-18 21:12 ` Mauro Carvalho Chehab
2025-08-19 15:01 ` Paul E. McKenney
2025-08-12 14:42 ` Paul E. McKenney
2025-08-12 15:55 ` Laurent Pinchart
2025-08-18 21:07 ` Mauro Carvalho Chehab
2025-08-19 15:15 ` Paul E. McKenney
2025-08-19 15:23 ` James Bottomley
2025-08-19 16:16 ` Mauro Carvalho Chehab
2025-08-20 21:44 ` Paul E. McKenney
2025-08-21 10:23 ` Mauro Carvalho Chehab
2025-08-21 16:50 ` Steven Rostedt
2025-08-21 17:30 ` Mauro Carvalho Chehab
2025-08-21 17:36 ` Luck, Tony
2025-08-21 18:01 ` Mauro Carvalho Chehab
2025-08-21 19:03 ` Steven Rostedt
2025-08-21 19:45 ` Mauro Carvalho Chehab
2025-08-21 21:21 ` Paul E. McKenney
2025-08-21 21:32 ` Steven Rostedt
2025-08-21 21:49 ` Paul E. McKenney
2025-08-21 17:53 ` Steven Rostedt
2025-08-21 18:32 ` Mauro Carvalho Chehab
2025-08-21 19:07 ` Steven Rostedt
2025-08-21 19:52 ` Mauro Carvalho Chehab
2025-08-21 21:23 ` Paul E. McKenney
2025-08-22 7:55 ` Geert Uytterhoeven
2025-08-21 20:38 ` Jiri Kosina
2025-08-21 21:18 ` Jiri Kosina
2025-08-21 20:46 ` Paul E. McKenney
2025-08-18 17:53 ` Rafael J. Wysocki
2025-08-18 18:32 ` James Bottomley
2025-08-19 15:14 ` Paul E. McKenney
2025-08-18 19:13 ` Mauro Carvalho Chehab
2025-08-18 19:19 ` Jiri Kosina
2025-08-18 19:44 ` Rafael J. Wysocki
2025-08-18 19:47 ` Jiri Kosina
2025-08-18 22:44 ` Laurent Pinchart
2025-08-06 8:17 ` Dan Carpenter
2025-08-06 10:13 ` Mark Brown
2025-08-12 14:36 ` Ben Dooks
2025-09-15 18:01 ` Kees Cook
2025-09-15 18:29 ` dan.j.williams
2025-09-16 15:36 ` James Bottomley
2025-09-16 9:39 ` Jiri Kosina
2025-09-16 15:31 ` James Bottomley
2025-09-16 14:20 ` Steven Rostedt
2025-09-16 15:00 ` Mauro Carvalho Chehab
2025-09-16 15:48 ` Steven Rostedt
2025-09-16 16:06 ` Luck, Tony
2025-09-16 16:58 ` H. Peter Anvin
2025-09-16 23:30 ` Kees Cook
2025-09-17 15:16 ` Steven Rostedt
2025-09-17 17:02 ` Laurent Pinchart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250917170250.GB10145@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=jkosina@suse.com \
--cc=kees@kernel.org \
--cc=ksummit@lists.linux.dev \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox