From: Greg KH <gregkh@linuxfoundation.org>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
ksummit@lists.linux.dev
Subject: Re: [MAINTAINERS SUMMIT] Hidden commits from next (aka why maintainers hoard them in backpack)
Date: Thu, 11 Sep 2025 14:58:09 +0200 [thread overview]
Message-ID: <2025091132-flattered-boned-6094@gregkh> (raw)
In-Reply-To: <ed3b0fbf-2518-4a96-9ca5-22ed37965395@kernel.org>
On Thu, Sep 11, 2025 at 02:42:47PM +0200, Krzysztof Kozlowski wrote:
> On 11/09/2025 14:33, Laurent Pinchart wrote:
> > On Thu, Sep 11, 2025 at 02:31:23PM +0200, Bartosz Golaszewski wrote:
> >> On Thu, 11 Sept 2025 at 14:27, Laurent Pinchart wrote:
> >>>
> >>>> Just a friendly note, Laurent, I appreciate your work and I do not want
> >>>> to point that you committed it incorrectly. In the contrary - your
> >>>> commit is right, but your upstream maintainer stops you from including
> >>>> this in linux-next. My aim here is only to discuss and improve the process.
> >>>
> >>> I would be happy to have my tree included in linux-next. I'm worried
> >>> that the fact that the media subsystem cherry-picks my pull requests
> >>> instead of merging them would cause issues though. Am I worrying
> >>> needlessly, or is that a real issue ?
> >>
> >> Stephen Rothwell will send you automated emails about duplicate
> >> commits being present in linux-next - one coming from your downstream
> >> and one rebased in your upstream maintainer's tree.
> >
> > So the question is how to redirect Stephen's complaints to the person
> > who is responsible for the issue in the first place :-)
>
>
> That's a real issue, so your worrying is correct, even if Stephen adds
> exception for certain trees causing commit duplicates.
>
> If commit appears twice in linux-next people might put the wrong one in
> "Fixes" or "commit SHA" references. Duplicate commit is a redundant
> information and waste of people's time (vide discussion about Link: tags).
>
>
> I think DRM is even weirder here - already discussed in the past - where
> they cherry-pick commits between branches causing duplicates and
> reference other commit while not feeding them to linux-next promptly. I
> still remember the one RC pull request from Intel to DRM which had
> commits like:
>
> Signed-off-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Link: https://patchwork.freedesktop.org/patch/msgid ...
> (cherry picked from commit 97b6784753da06d9d40232328efc5c5367e53417)
> Signed-off-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
>
> and when on linux-next you try to figure our what was the source here,
> you get:
> $ git show 97b6784753da06d9d40232328efc5c5367e53417
> fatal: bad object 97b6784753da06d9d40232328efc5c5367e53417
> (Tried with repo having several maintainer repos and the linux-next THAT
> time; now it works...)
>
> I also remember Linus pointing out some of these duplicates on mailing list.
I've pointed out the drm "mess" many times, it drives me crazy
attempting to track stuff being properly backported to stable trees all
the time...
thanks,
greg k-h
next prev parent reply other threads:[~2025-09-11 12:58 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-11 11:04 Krzysztof Kozlowski
2025-09-11 11:44 ` Krzysztof Kozlowski
2025-09-11 12:05 ` Mark Brown
2025-09-11 18:45 ` Dan Carpenter
2025-09-11 12:06 ` Jiri Kosina
2025-09-11 12:10 ` Krzysztof Kozlowski
2025-09-11 13:18 ` James Bottomley
2025-09-11 13:49 ` Mark Brown
2025-09-11 15:32 ` James Bottomley
2025-09-11 16:02 ` Mark Brown
2025-09-11 16:11 ` James Bottomley
2025-09-11 16:50 ` Mark Brown
2025-09-11 12:27 ` Laurent Pinchart
2025-09-11 12:31 ` Bartosz Golaszewski
2025-09-11 12:33 ` Laurent Pinchart
2025-09-11 12:42 ` Krzysztof Kozlowski
2025-09-11 12:58 ` Greg KH [this message]
2025-09-12 9:03 ` Dan Carpenter
2025-09-11 12:34 ` Geert Uytterhoeven
2025-09-11 12:35 ` Johannes Berg
2025-09-11 12:36 ` Laurent Pinchart
2025-09-11 12:48 ` Mark Brown
2025-09-11 12:47 ` Krzysztof Kozlowski
2025-09-11 12:53 ` Laurent Pinchart
2025-09-11 13:40 ` Mark Brown
2025-09-11 14:25 ` Steven Rostedt
2025-09-11 19:29 ` Laurent Pinchart
2025-09-11 19:43 ` Steven Rostedt
2025-09-12 9:52 ` Vlastimil Babka
2025-09-12 17:45 ` Steven Rostedt
2025-09-11 12:49 ` Sasha Levin
2025-09-12 11:55 ` Krzysztof Kozlowski
2025-12-14 1:19 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025091132-flattered-boned-6094@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=bartosz.golaszewski@linaro.org \
--cc=krzk@kernel.org \
--cc=ksummit@lists.linux.dev \
--cc=laurent.pinchart@ideasonboard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox