From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6D9441F462B; Wed, 19 Feb 2025 15:13:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739978012; cv=none; b=UJdIX9yhbLxVYQiO5GjKr6xEetI27U+2CF9cLTjtw63TpxW8SRIl/oBCa7kE2kxN3flwodfZw8ghvJlHgWF6v6boNxsAS/L2TXq3y1Ecxg82YTQMkp640Y6Q1jc2HecA3h2hYs84+9fzz1cdqg57d9fD9VS4uzaIJSxbL7vcT1o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739978012; c=relaxed/simple; bh=f3utMKar8wWZicCDrmR+Q7OczOccOOJkFA/H5zQyvrw=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=uKDk+6zx2Gromu/csa2aVD9B+9WafHHmYxv4MNn/s5jbJ5H6oN5sZeGWn/p19+ZFcy+qpI82i2FUV4JbSmKOQac8+kT7S351qgbhgPpkwNsanQXljkvMMqpuHib3zyvRmnU6GT7XGUXDBvGPMXlqY8mIEDjZX8cHGm4vFTWxnIY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id C7DD2C4CED1; Wed, 19 Feb 2025 15:13:29 +0000 (UTC) Date: Wed, 19 Feb 2025 10:13:53 -0500 From: Steven Rostedt To: James Bottomley Cc: Dan Carpenter , Christoph Hellwig , Miguel Ojeda , rust-for-linux , Linus Torvalds , Greg KH , David Airlie , linux-kernel@vger.kernel.org, ksummit@lists.linux.dev Subject: Re: Rust kernel policy Message-ID: <20250219101353.32bed6c9@gandalf.local.home> In-Reply-To: <2bcf7cb500403cb26ad04934e664f34b0beafd18.camel@HansenPartnership.com> References: <2bcf7cb500403cb26ad04934e664f34b0beafd18.camel@HansenPartnership.com> X-Mailer: Claws Mail 3.20.0git84 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: ksummit@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 19 Feb 2025 09:14:17 -0500 James Bottomley wrote: > I look at most of the bugfixes flowing through subsystems I watch and a > lot of them are in error legs. Usually around kfree cockups (either > forgetting or freeing to early). Could we possibly fix a lot of this > by adopting the _cleanup_ annotations[1]? I've been working in systemd > code recently and they seem to make great use of this for error leg > simplification. And the tracing subsystem has already been moving in that direction. https://lore.kernel.org/all/20241219201158.193821672@goodmis.org/ https://lore.kernel.org/all/173630223453.1453474.6442447279377996686.stgit@devnote2/ I need to add this logic to my tracing libraries too. That's on my TODO list. -- Steve