From: Steven Rostedt <rostedt@goodmis.org>
To: Jiri Kosina <jikos@kernel.org>
Cc: ksummit@lists.linux.dev
Subject: Re: [MAINTAINERS SUMMIT] Merge tree too flat?
Date: Tue, 4 Jun 2024 18:45:06 -0400 [thread overview]
Message-ID: <20240604184506.007c4682@gandalf.local.home> (raw)
In-Reply-To: <nycvar.YFH.7.76.2406050028090.24940@cbobk.fhfr.pm>
On Wed, 5 Jun 2024 00:34:04 +0200 (CEST)
Jiri Kosina <jikos@kernel.org> wrote:
> On Tue, 4 Jun 2024, Steven Rostedt wrote:
>
> > Note, the git tree may hide some hierarchy too. For example, I'm starting
> > to do pulls from Daniel Bristot for his rtla tooling. But since I have a
> > topic branch for his work, I just do a fetch from his pull request, and
> > then copy his pull request cover letter (with some tweaks) directly to Linus.
>
> Right; that's exactly how it should be done in my view.
>
> But if Daniel's tree has always fed into yours (no matter whether the 'git
> merge' way or 'apply patch' way), in doesn't really decrease the net
> effort one level above.
I disagree. I use to take his patches and pull them in. But having him do
it, and also write the pull request, makes my job so much easier.
Note, I review his work, but not some much as if I were to review his
patches. I look at it at a different level when it's a pull request. I
trust Daniel enough to not go through his work with a fine comb, but
instead just look to make sure the general idea is sound.
How would imagine this being different than having a hierarchy. I would be
doing the same thing if I had done a merge. Actually, it is a merge, but I
do a "fast-forward" merge since he's the only one modifying the topic
branch. And it would look funny if I had done a merge, and then send the
same merge to Linus, where we have two merges back to back. Hence why I do
a fast-forward merge and use his pull request commit message in the one I
send to Linus.
-- Steve
next prev parent reply other threads:[~2024-06-04 22:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-04 22:03 Jiri Kosina
2024-06-04 22:21 ` Steven Rostedt
2024-06-04 22:34 ` Jiri Kosina
2024-06-04 22:45 ` Steven Rostedt [this message]
2024-06-05 11:31 ` Mark Brown
2024-06-14 9:15 ` Wolfram Sang
2024-06-04 22:33 ` Sasha Levin
2024-06-04 22:38 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240604184506.007c4682@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=jikos@kernel.org \
--cc=ksummit@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox