From: Steven Rostedt <rostedt@goodmis.org>
To: Jiri Kosina <jikos@kernel.org>
Cc: ksummit@lists.linux.dev
Subject: Re: [MAINTAINERS SUMMIT] Merge tree too flat?
Date: Tue, 4 Jun 2024 18:21:37 -0400 [thread overview]
Message-ID: <20240604182137.2cfdc0b2@gandalf.local.home> (raw)
In-Reply-To: <nycvar.YFH.7.76.2406041151590.24940@cbobk.fhfr.pm>
On Wed, 5 Jun 2024 00:03:45 +0200 (CEST)
Jiri Kosina <jikos@kernel.org> wrote:
> On last year's maintainer summit, there was a session where Linus asked
> the participants to bring up topics / questions [1].
>
> I myself was the one raising the concern of the merge tree feeling a
> little bit too flat, and there seemed to be general agreement on that.
>
> Checking the git repository as of now, it seems like we have not changed
> anything in that respect over the past year, and a lot of things are going
> directly to Linus although they could be cascaded a little bit better,
> contributing to better load-balancing on all maintainer levels (including
> the top-level one, of course).
Note, the git tree may hide some hierarchy too. For example, I'm starting
to do pulls from Daniel Bristot for his rtla tooling. But since I have a
topic branch for his work, I just do a fetch from his pull request, and
then copy his pull request cover letter (with some tweaks) directly to Linus.
Although it may look like I'm pulling in Daniel's patches, I'm not. I
review them, but I'm more of a middle man between him and Linus.
>
> I'd like to propose this as a proper discussion topic slot this year, by
> e.g. looking at:
>
> - the actual numbers and current merge graph
Now one thing I have started doing at Linus's request, is to make more
topic branches. This way if there's something that he doesn't like, he can
give it a line-item-veto, and I don't have to rebase everything.
This actually makes things easier to maintain. Perhaps maintainers should just
start splitting up their work? This may increase Linus's pull requests, but
it may also make it it easier for him to do those pulls. It is similar to
breaking up a change into many patches. Yes, there may be more patches to
review, but those patches are much easier to review than one big one. I
think the same can be said for pull requests.
The sad part is, the more topic branches you have, it will make the tree
look even flatter.
>
> - is this really something that could improve maintainer load (on all
> levels) and throughput if done properly?
Topic branches.
>
> - how could we motivate maintainers to change the process and delegate
> more into proper hierarchical sub-trees?
Now with more topic branches, it may be even easier to get others to take
over. Daniel does changes for rtla, and Masami Hiramatsu does all the probe
logic. Perhaps the first step is just to have maintainers split up their
work.
-- Steve
>
> - potentially identify particular trees and changes that could be made in
> the merge graph/path to improve the process
>
> [1] https://lwn.net/Articles/952146/
>
next prev parent reply other threads:[~2024-06-04 22:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-04 22:03 Jiri Kosina
2024-06-04 22:21 ` Steven Rostedt [this message]
2024-06-04 22:34 ` Jiri Kosina
2024-06-04 22:45 ` Steven Rostedt
2024-06-05 11:31 ` Mark Brown
2024-06-14 9:15 ` Wolfram Sang
2024-06-04 22:33 ` Sasha Levin
2024-06-04 22:38 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240604182137.2cfdc0b2@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=jikos@kernel.org \
--cc=ksummit@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox