From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C4593156CD for ; Tue, 29 Aug 2023 12:54:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EF163C433C7; Tue, 29 Aug 2023 12:54:07 +0000 (UTC) Date: Tue, 29 Aug 2023 08:54:05 -0400 From: Steven Rostedt To: Vegard Nossum Cc: Leon Romanovsky , Linus Torvalds , Jakub Kicinski , Linus Walleij , Alexei Starovoitov , Andrew Lunn , Laurent Pinchart , Luis Chamberlain , Josef Bacik , ksummit@lists.linux.dev, Jeff Layton , Song Liu Subject: Re: [MAINTAINERS SUMMIT] Maintainer burnout Message-ID: <20230829085405.5faf3b51@rorschach.local.home> In-Reply-To: References: <20230816180808.GB2919664@perftesting> <20230817093914.GE21668@pendragon.ideasonboard.com> <44814ed5-7bab-4e56-9ca6-189870f97f41@lunn.ch> <20230817081957.1287b966@kernel.org> <20230818080949.7b17b0d5@kernel.org> <20230819064537.GM22185@unreal> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: ksummit@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 21 Aug 2023 21:23:18 +0200 Vegard Nossum wrote: > Can we maybe adjust the standards of the Reviewed-by: tag to mean that > the person has looked at the patch (or an earlier version of it) and > provided comments that show they actually put some effort into it? > For example, if a patch is changing a function (as patches often do), > the reviewer should add a line saying "error paths in foo() lgtm" > and not just tack on their Reviewed-by: line. > > This adjustment would make it harder to just slap a Reviewed-by: on a > patch, but it would also make it easier to get your name in the > changelog provided that you actually put the effort in. Note, when I can't do a real review, I just slap an Acked-by tag to it. That to me means LGTM, but I haven't looked deep into it. -- Steve