Re: Potential static analysis ideas

[Dan Carpenter <dan.carpenter@oracle.com>]

On Mon, Jul 26, 2021 at 11:08:01AM +0200, Hannes Reinecke wrote:
> And that I would consider a coding error.
> If a function is able to return an error pointer it should _always_ return
> an error pointer; here it would be trivial to return -ENXIO instead of NULL
> in the first condition.
> 
> Not doing so is just sloppy programming IMO.
> 
> Cheers,

But it's not an error.  One place where this bit me recently was I was
trying to debug some code and I added:

	if (err)
		printk("function blah returned err");

But their list iterator returns an error code when it got to the end of
the list so I was flooded with errors.  It be nicer "if we can't
allocate enough memory for the next item return an error pointer.  If we
come to the end of the loop then return NULL"

regards,
dan carpenter