From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 0A81DF2D for ; Wed, 3 Jul 2019 07:51:56 +0000 (UTC) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 6CE7270D for ; Wed, 3 Jul 2019 07:51:55 +0000 (UTC) Date: Wed, 3 Jul 2019 09:51:51 +0200 From: Greg KH To: Kees Cook Message-ID: <20190703075151.GA3950@kroah.com> References: <37eb32f3-f341-b1d8-293b-c119ae278b4f@linuxfoundation.org> <1562082713.3321.38.camel@HansenPartnership.com> <201907020926.FB19EDEBCC@keescook> <1562103238.3321.66.camel@HansenPartnership.com> <1562106408.29304.11.camel@HansenPartnership.com> <20190702224347.GJ3032@mit.edu> <201907021559.FEC3922@keescook> <20190702231858.GK3032@mit.edu> <201907021638.3D0AC00@keescook> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201907021638.3D0AC00@keescook> Cc: James Bottomley , ksummit-discuss@lists.linuxfoundation.org Subject: Re: [Ksummit-discuss] [MAINTAINERS SUMMIT] Patch version changes in commit logs? List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, Jul 02, 2019 at 04:41:35PM -0700, Kees Cook wrote: > On Tue, Jul 02, 2019 at 07:18:58PM -0400, Theodore Ts'o wrote: > > On Tue, Jul 02, 2019 at 04:04:31PM -0700, Kees Cook wrote: > > > > Step 1) git config am.messageid true > > > > > > This is a lossy action: we don't know which list the ID came from (e.g. > > > many things are sent to subsystem lists and not lkml). > > > > Why do we need to care which list the ID came from? Many messages are > > cc'ed to multiple lists that are archived on lore.kernel.org. And it > > doesn't matter: > > > > lore.kernel.org/r/ > > > > ... will work without needing to know which list it was sent to. > > > > > > Step 2) Write and install a .git/hooks/applypatch-msg script which > > > > looks for Message-Id: and transmogrifies that line to a > > > > Link: trailer, using the lore.kernel.org URL template > > > > > > I think the lorifier.py[1] mentioned earlier has 90% of the "step 2" > > > logic, including caching the lore list mappings. Is there a "git am" hook > > > we could build on instead? /me looks. Yes; seems to be "applypatch-msg"? > > > Unclear if the email headers are included... > > > > applypatch-msg is the git hoook I had suggested above. > > > > The documentation states: > > > > This hook is invoked by git-am[1]. It takes a single parameter, > > the name of the file that holds the proposed commit log > > message. Exiting with a non-zero status causes git am to abort > > before applying the patch. > > > > The hook is allowed to edit the message file in place, and can be > > used to normalize the message into some project standard > > format. It can also be used to refuse the commit after inspecting > > the message file. > > > > > > That to me says the e-mail headers have already been stripped. > > Fortunately, using am.messageid=true should work since that is part of > > the proposed commit message. > > This works for me: > > $ git config am.messageid true > $ cat >.git/hooks/applypatch-msg <<'EOF' > #!/bin/sh > . git-sh-setup > perl -pi -e 's|^Message-Id:\s*]+)>?$|Link: https://lore.kernel.org/r/$1|g;' "$1" > test -x "$GIT_DIR/hooks/commit-msg" && > exec "$GIT_DIR/hooks/commit-msg" ${1+"$@"} > : > EOF > $ chmod a+x .git/hooks/applypatch-msg I just tried this on my tree and it works great! thanks for this, I'll start using it on my trees and it also forces me to finally get the linux-usb tree into lore... thanks, greg k-h