From: Steven Rostedt <rostedt@goodmis.org>
To: Jani Nikula <jani.nikula@intel.com>
Cc: Ksummit-discuss@lists.linuxfoundation.org
Subject: Re: [Ksummit-discuss] [MAINTAINERS SUMMIT] Moving debugfs file systems into sysfs
Date: Tue, 2 Oct 2018 09:11:44 -0400 [thread overview]
Message-ID: <20181002091144.48f4e27f@gandalf.local.home> (raw)
In-Reply-To: <87va6kkagg.fsf@intel.com>
On Tue, 02 Oct 2018 11:40:47 +0300
Jani Nikula <jani.nikula@intel.com> wrote:
> On Mon, 01 Oct 2018, Steven Rostedt <rostedt@goodmis.org> wrote:
> > At Kernel Recipes, I talked with some people that have mature
> > interfaces in the debugfs directory, but they can not access them on
> > systems that have debugfs disabled. What would be the process to have
> > these systems move out of debugfs? Should they create their own fs and
> > be mounted in /sys/kernel, with a dedicated directory if the file system
> > is enabled in the kernel (I had tracefs do that).
> >
> > Is this something we should discuss at Maintainers Summit? What is the
> > process for mature debugfs directories? What's the justification to
> > have them moved? Is there a better answer for this?
>
> I have a semi-related topic, hopefully not a complete thread
> hijack... ;)
>
> I think module parameters should primarily be viewed as debug knobs
> rather than ABI. Things should just work instead of requiring the user
> to tweak module parameters. Of course, there's the whole spectrum
> between ABI and "unsafe" module parameters, and parameters get added for
> a plethora of reasons.
>
> However, all module parameters show up in sysfs instead of, say,
> debugfs. Many debug options otherwise suitable for debugfs alone are
> added as module parameters because of the convenience; with just a few
> lines you can add the module parameter, get the sysfs, and have the
> value be set before probe. There's nothing that compares, really.
You mean to select some of the parameters to be debugfs knobs?
(obviously we don't want all of them there).
>
> I suppose primarily I'd like to find a convenient way to move module
> parameters to debugfs, so the other way round than Steven. Do others
> struggle with this? Any ideas, thoughts, pointers?
>
I haven't had any issues, personally.
-- Steve
next prev parent reply other threads:[~2018-10-02 13:11 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-01 18:04 Steven Rostedt
2018-10-02 1:18 ` Greg KH
2018-10-02 1:26 ` Greg KH
2018-10-02 13:07 ` Steven Rostedt
2018-10-02 14:59 ` Olof Johansson
2018-10-02 16:00 ` Shuah Khan
2018-10-02 16:17 ` Greg Kroah-Hartman
2018-10-02 16:30 ` Greg Kroah-Hartman
2018-10-02 21:37 ` Mauro Carvalho Chehab
2018-10-02 21:57 ` Shuah Khan
2018-10-02 22:22 ` Greg Kroah-Hartman
2018-10-03 12:59 ` Jan Kara
2018-10-03 13:40 ` Greg Kroah-Hartman
2018-10-03 13:44 ` Jiri Kosina
2018-10-03 14:32 ` Greg Kroah-Hartman
2018-10-03 14:33 ` Greg Kroah-Hartman
2018-10-04 11:50 ` Jiri Kosina
2018-10-03 14:53 ` Jan Kara
2018-10-04 16:11 ` Takashi Iwai
2018-10-03 14:11 ` Shuah Khan
2018-10-03 10:06 ` Sudeep Holla
2018-10-03 13:13 ` Mark Brown
2018-10-03 14:52 ` Sudeep Holla
2018-10-02 8:40 ` Jani Nikula
2018-10-02 13:11 ` Steven Rostedt [this message]
2018-10-02 21:32 ` Mauro Carvalho Chehab
2018-10-03 6:23 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181002091144.48f4e27f@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=Ksummit-discuss@lists.linuxfoundation.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox