On Thu, Sep 20, 2018 at 11:53:26AM +0200, Daniel Vetter wrote:
> On Thu, Sep 20, 2018 at 11:12 AM, Rafael J. Wysocki <rjw@rjwysocki.net> wrote:

> > Also, the second paragraph in there openly suggests that maintainers are now
> > expected to reject contributions from the people who behave inappropriately
> > in their view.  Does this mean that I'm expected to reject correct code changes
> > (maybe including bug fixes and maybe even security-critical ones) from a person
> > whose behaviors "deem inappropriate, threatening, offensive, or harmful" in
> > my view?

> Ultimately, yes. On dri-devel we didn't yet have to pull out that
> threat yet. If you look at other communities, a permanent ban (which
> is what you defacto do if you reject all contributions from someone)
> is an extremely rare measure.

> What we have done is temporarily suspend people's commit rights, so
> they can cool down a bit. Or making it clear that we might remove them
> from maintainer duties. The amount of damage a maintainer/committer
> can do is much bigger than someone just submitting patches, so usually
> that's all that's needed. All while making it clear that their
> contributions are still very much welcome. But someone who really only
> wreaks a massive wake of destruction, even if their patches themselves
> are fine, will be thrown out completely from dri-devel. Just not worth
> to deal with.

I did once run into a situation where I just flat out refused to apply
what was apparently a bugfix patch from someone due to the fact that the
commit message consisted entirely of abusive comments about everyone
involved in introducing the bug and they refused to improve the commit
message in any way.  It didn't help that they weren't willing to
describe the bug itself other than to make derogatory comments about
those who couldn't see the issue.  This is just an edge case that's
really extreme and really rare.