From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 60F98D08 for ; Fri, 7 Sep 2018 02:45:44 +0000 (UTC) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 0B055623 for ; Fri, 7 Sep 2018 02:45:43 +0000 (UTC) Date: Thu, 6 Sep 2018 22:45:41 -0400 From: Steven Rostedt To: Linus Torvalds Message-ID: <20180906224541.27a9c8fe@vmware.local.home> In-Reply-To: References: <20180904201620.GC16300@sasha-vm> <20180905101710.73137669@gandalf.local.home> <20180907004944.GD16300@sasha-vm> <20180907014930.GE16300@sasha-vm> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: ksummit Subject: Re: [Ksummit-discuss] [MAINTAINERS SUMMIT] Bug-introducing patches List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thu, 6 Sep 2018 19:31:18 -0700 Linus Torvalds wrote: > What do you suggest you do about a patch that is a bug fix? Delay it > until it has two weeks of testing? Which it won't get, because nobody > actually runs it until it is merged? A good statistic to take is to see what found a bug that was caused by something added after rc5. Was it a bot (then there's credence that running through linux-next would be helpful). Is it because someone triggered it because it was in Linus's tree (which means the bug wouldn't show up until it hit Linus's tree). Or was it something that was discovered when it got into the distros? Really, the only testing coverage that a patch gets in linux-next is by the bots that are run on them. I will agree that the number of bots and automated tests are getting better. I don't push even late fixes to Linus without waiting for the zero day bot to give me the OK, because sometimes it finds a subtle mistake I made, which would embarrass me if it was found after I pushed it to Linus. Another issue about having fixes sit in linux-next for some time after -rc5, is that by that time, linux-next is filled with new development code waiting for the next merge window. A subtle fix for a bug that wasn't caught by linux-next in the first place (how else would that bug still be around by rc5?) is highly likely not to catch a bug with the fix to that subtle bug. -- Steve