ksummit.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Jan Kara <jack@suse.cz>
To: Jiri Kosina <jikos@kernel.org>
Cc: Greg KH <gregkh@linuxfoundation.org>,
	"ksummit-discuss@lists.linuxfoundation.org"
	<ksummit-discuss@lists.linuxfoundation.org>
Subject: Re: [Ksummit-discuss] [MAINTAINER SUMMIT] Stable trees and release time
Date: Wed, 5 Sep 2018 10:16:58 +0200	[thread overview]
Message-ID: <20180905081658.GB24902@quack2.suse.cz> (raw)
In-Reply-To: <nycvar.YFH.7.76.1809050838570.15880@cbobk.fhfr.pm>

On Wed 05-09-18 08:48:03, Jiri Kosina wrote:
> On Tue, 4 Sep 2018, Sasha Levin via Ksummit-discuss wrote:
> 
> > This is exactly what would happen if you ask Greg to go on some sort of 
> > a schedule - he'll just defer the .Z+1 commits to what would have been 
> > the .Z+2 release, so you don't really win anything by moving to a 
> > stricter schedule.
> 
> You potentially do win one thing, and that's review (or at least 
> possibility of review).
> 
> With current cadence, I'd put all my bets on the fact that everybody is 
> just completely ignoring the e-mails about patches being queued for stable 
> inclusion. It's just way, way too many of them, it's a neverending, 
> contignuous, overwhelming stream.
> 
> If this would be happening at smaller cadence, chances of people (original 
> patch author, reviewers and maintainer) actually investing brain energy 
> into evaluating whether particular patch is suitable for particular stable 
> without introducing backporting regression would be much higher.

So I agree that with current amount of patches in stable tree, the review
is cursory at best. However that does not really seem to be related to
the frequency of stable releases (which is what I believe Laura complains
about in this thread) but rather to the amount of patches going into
stable.

> Also, it's not only the cadence, but the patch selection criteria that 
> contributes to killing the review of stable patches; the bar for stable 
> tree acceptance is much lower than it used to be (really, just look at the 
> criteria formulated in stable-kernel-rules.rst and then match them against 
> the patches that actually land in the tree); so we'd need both, otherwise 
> I think the trend of distros moving away from stable is inevitable (as "no 
> review" basically equals "we're not obsessed about regressions", and 
> distros don't want that, I think).

I think distros usually have established feedback loop (through bugzilla
etc.) so they rely on "if there's a bug, users will report it and we'll fix
it" strategy. So they need to fix proactively only really nasty bugs which
you don't want to ever happen. OTOH for products like embedded devices,
that feedback loop is much weaker (it's difficult for average user to
extract info about the problem from the device) so I can understand they
need to be much more aggressive in picking fixes (since even with current
stable cadence it is a net win in the amount of bugs your wide user base is
going to hit).

So I think the bar for patch acceptance for these two kinds of deployments
is rather different and Greg decided to accomodate more the second one.
Distros now have to decide whether they relax their rules as well or
whether they do their own stricter selection. At least that was the outcome
of the last stable-tree discussion for me...

								Honza
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR

  reply	other threads:[~2018-09-05  8:17 UTC|newest]

Thread overview: 74+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-04 20:58 Laura Abbott
2018-09-04 21:12 ` Jiri Kosina
2018-09-05 14:31   ` Greg KH
2018-09-04 21:22 ` Justin Forbes
2018-09-05 14:42   ` Greg KH
2018-09-05 15:10     ` Mark Brown
2018-09-05 15:10     ` Sasha Levin
2018-09-05 16:19     ` Guenter Roeck
2018-09-05 18:31     ` Laura Abbott
2018-09-05 21:23     ` Justin Forbes
2018-09-06  2:17     ` Eduardo Valentin
2018-09-04 21:33 ` Sasha Levin
2018-09-04 21:55   ` Guenter Roeck
2018-09-04 22:03     ` Laura Abbott
2018-09-04 23:14       ` Sasha Levin
2018-09-04 23:43         ` Guenter Roeck
2018-09-05  1:17           ` Laura Abbott
2018-09-06  3:56             ` Benjamin Gilbert
2018-09-04 21:58   ` Laura Abbott
2018-09-05  4:53     ` Sasha Levin
2018-09-05  6:48   ` Jiri Kosina
2018-09-05  8:16     ` Jan Kara [this message]
2018-09-05  8:32       ` Jiri Kosina
2018-09-05  8:56         ` Greg KH
2018-09-05  9:13           ` Geert Uytterhoeven
2018-09-05  9:33             ` Greg KH
2018-09-05 10:11           ` Mark Brown
2018-09-05 14:44             ` Steven Rostedt
2018-09-05  9:58         ` James Bottomley
2018-09-05 10:47           ` Mark Brown
2018-09-05 12:24             ` James Bottomley
2018-09-05 12:53               ` Jiri Kosina
2018-09-05 13:05                 ` Greg KH
2018-09-05 13:15                   ` Jiri Kosina
2018-09-05 14:00                     ` Greg KH
2018-09-05 14:06                     ` Sasha Levin
2018-09-05 21:02                       ` Jiri Kosina
2018-09-05 16:39                 ` James Bottomley
2018-09-05 17:06                   ` Dmitry Torokhov
2018-09-05 17:33                   ` Steven Rostedt
2018-09-05 13:03               ` Takashi Iwai
2018-09-05 13:27                 ` Daniel Vetter
2018-09-05 14:05                   ` Greg KH
2018-09-05 15:54                     ` Daniel Vetter
2018-09-05 16:19                       ` Sasha Levin
2018-09-05 16:26                         ` Daniel Vetter
2018-09-05 19:09                           ` Sasha Levin
2018-09-05 20:18                             ` Sasha Levin
2018-09-05 20:33                               ` Daniel Vetter
2018-09-05 14:20                 ` Sasha Levin
2018-09-05 14:30                   ` Takashi Iwai
2018-09-05 14:41                     ` Sasha Levin
2018-09-05 14:46                       ` Takashi Iwai
2018-09-05 14:54                         ` Sasha Levin
2018-09-05 15:12                           ` Takashi Iwai
2018-09-05 15:19                           ` Thomas Gleixner
2018-09-05 15:29                             ` Sasha Levin
2018-09-05 13:16               ` Mark Brown
2018-09-05 14:27                 ` Sasha Levin
2018-09-05 14:50                   ` Mark Brown
2018-09-05 15:00                     ` Sasha Levin
2018-09-05 10:28       ` Thomas Gleixner
2018-09-05 11:20         ` Jiri Kosina
2018-09-05 14:41           ` Thomas Gleixner
2018-09-05 15:18             ` Steven Rostedt
2018-09-06  8:48               ` Thomas Gleixner
2018-09-06 12:47                 ` Thomas Gleixner
2018-09-04 21:49 ` Guenter Roeck
2018-09-04 22:06   ` Laura Abbott
2018-09-04 23:35     ` Guenter Roeck
2018-09-05  1:45       ` Laura Abbott
2018-09-05  2:54         ` Guenter Roeck
2018-09-05  8:31           ` Jan Kara
2018-09-05  3:44 ` Eduardo Valentin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180905081658.GB24902@quack2.suse.cz \
    --to=jack@suse.cz \
    --cc=gregkh@linuxfoundation.org \
    --cc=jikos@kernel.org \
    --cc=ksummit-discuss@lists.linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox