On Sun, Jun 25, 2017 at 11:32:45PM +0200, Alexandre Belloni wrote: > Hi, > > On 25/06/2017 at 22:05:29 +0300, Leon Romanovsky wrote: > > On Sun, Jun 25, 2017 at 11:37:12AM -0700, Linus Torvalds wrote: > > > On Sun, Jun 25, 2017 at 11:19 AM, Leon Romanovsky wrote: > > > > > > > > Great, so why are we continuing to allow patches with MODULE_VERSION and > > > > DRIVER_VERSION changes? > > > > > > I suspect they just haven't caused problems elsewhere. > > > > > > And honestly, they aren't that common. Grepping for MODULE_VERSION and > > > DRIVER_VERSION shows more than I would like, but we're talking > > > hundreds, not thousands (and lots of them are basically dead, stale > > > code - ATA etc, or just joke names - usb). > > > > I see it differently, from my point of view, it is pretty active, > > especially in the subsystems where new drivers are added more often, > > but if you say that the policy exists, it is enough for me. > > > > A while ago, I went and removed all of them from the RTC subsystem. I assume that you are referring to the commit fa5691131a87 ("rtc: remove useless DRV_VERSION"). Let's see how similar patch will be accepted in RDMA, netdev communities. Thanks > > > > -- > Alexandre Belloni, Free Electrons > Embedded Linux and Kernel engineering > http://free-electrons.com