ksummit.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <mchehab@s-opensource.com>
To: Matthew Wilcox <willy6545@gmail.com>
Cc: ksummit-discuss@lists.linux-foundation.org
Subject: Re: [Ksummit-discuss] [MAINTAINERS SUMMIT] Documentation issues
Date: Sun, 25 Jun 2017 21:58:27 -0300	[thread overview]
Message-ID: <20170625215827.77cfec11@vento.lan> (raw)
In-Reply-To: <CAFhKne_ajkMYKmf-GXC28c_h+O1c0_=SDq-OFEaHHTKs8Qkvpg@mail.gmail.com>

Em Sun, 25 Jun 2017 17:32:31 -0400
Matthew Wilcox <willy6545@gmail.com> escreveu:

> I find documentation comes in the following bins:
> 
> 1. User documentation (possible sub-split into "how to use this from kernel
> space" and "how to use this from user space")
> 2. Information for someone who's interested in modifying the code. Possibly
> including architectural considerations (eg locking), performance, ideas for
> future improvement, etc.
> 3. Random swearing and abuse
> 
> I think the second and third categories of documentation should be kept out
> of the kernel books and left as plain comments by the code.

Having comments together the code is good, but sometimes it is not enough.

Just as an example, last week I received two patch series, from
different developers, that didn't get right how to collect quality
measurements from digital TV frontends. The functions they use are
documented via kernel-doc, and they looked on other drivers as examples.
Still, that was not not clear enough, as both developers didn't quite
get some things.

So, I had to write a few patches to actually explain how a
frontend driver is expected to collect statistics:
	https://patchwork.linuxtv.org/patch/42081/

And, today, I complemented with two additional texts:

	https://patchwork.linuxtv.org/patch/42115/
	https://patchwork.linuxtv.org/patch/42116/

As those explanations complement the kernel-doc macros from
dvb_frontend.h, they need cross references, in order for the
driver developer to better understand how things are connected,
and to avoid the need of having to explain everything that it is
already documented via kernel-doc tags, as can be seeing at:

	https://www.infradead.org/~mchehab/kernel_docs/media/kapi/dtv-core.html#digital-tv-frontend-kabi


That's just today's example. There are plenty of cases where we
need to add images and complex tables, etc that just don't fit
well as plain text.

Thanks,
Mauro

  parent reply	other threads:[~2017-06-26  0:58 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-23 18:39 Jonathan Corbet
2017-06-23 23:09 ` Rafael J. Wysocki
2017-06-24 12:03   ` Rafael J. Wysocki
2017-06-24 10:46 ` Mauro Carvalho Chehab
2017-06-24 12:20   ` Rafael J. Wysocki
2017-06-24 13:41     ` Mauro Carvalho Chehab
2017-06-25 20:56       ` Jiri Kosina
2017-06-26  1:20         ` Mauro Carvalho Chehab
2017-06-26 21:18           ` Rafael J. Wysocki
2017-06-26  5:58         ` Takashi Iwai
2017-06-26 21:28           ` Rafael J. Wysocki
2017-06-27  8:41             ` Daniel Vetter
2017-06-27 10:31               ` Mauro Carvalho Chehab
2017-06-26 22:18         ` Jonathan Corbet
2017-06-27 18:42           ` Bird, Timothy
2017-06-28 19:48           ` Geert Uytterhoeven
     [not found]       ` <CAFhKne8ZttmqWYJToCw9EDywzeMdp=eiFpoZ+O5xrzmKnpA09Q@mail.gmail.com>
     [not found]         ` <CAFhKne_W-EbjUd_Cm4kyBHrVK6K9r8Ss3gY0ogO1nztbQZYBEg@mail.gmail.com>
2017-06-25 21:32           ` Matthew Wilcox
2017-06-25 21:42             ` Rafael J. Wysocki
2017-06-26  1:15               ` Mauro Carvalho Chehab
2017-06-26 21:16                 ` Rafael J. Wysocki
2017-06-26  0:58             ` Mauro Carvalho Chehab [this message]
2017-06-25 16:13     ` Jonathan Corbet
2017-06-26 12:19 ` Mark Brown
2017-06-27  8:38   ` Daniel Vetter
2017-06-27 15:33     ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170625215827.77cfec11@vento.lan \
    --to=mchehab@s-opensource.com \
    --cc=ksummit-discuss@lists.linux-foundation.org \
    --cc=willy6545@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox