From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Joe Perches <joe@perches.com>
Cc: ksummit-discuss@lists.linux-foundation.org,
ksummit-discuss@lists.linuxfoundation.org
Subject: Re: [Ksummit-discuss] [CORE TOPIC] checkpatch/Codingstyle and trivial patch spam
Date: Wed, 14 Sep 2016 19:11:07 +0200 [thread overview]
Message-ID: <20160914170536.77fkhyiyikxc6jab@piout.net> (raw)
In-Reply-To: <1473834432.32273.21.camel@perches.com>
On 13/09/2016 at 23:27:12 -0700, Joe Perches wrote :
> On Wed, 2016-09-14 at 07:57 +0200, Julia Lawall wrote:
> > What types of changes are unacceptable?
>
> It's a mixed bag.
>
> Some maintainers reject all "style/whitespace changes".
> Some maintainers reject global consistency patches like
> int -> bool conversions.
> Some maintainers reject literal -> #define changes like
> 1 -> true and 0 -> false for booleans.
>
> Some of those maintainers are IMO misguided.
On my side, I usually take that kind of changes only when they come with
other substantial changes, especially when the code hasn't been touched
for a while.
The other thing that I find annoying are people using Coccinnelle or any
other static code analysis tool and sending patches without saying how
they found the alleged bug. Sometimes, this results in pointless
cleanups that haven't been tested by the patch author.
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-09-14 17:11 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-13 18:58 Christian Borntraeger
2016-09-13 19:18 ` Joe Perches
2016-09-13 19:45 ` Josh Triplett
2016-09-13 20:03 ` Jonathan Corbet
2016-09-13 22:14 ` Joe Perches
2016-09-14 5:29 ` Julia Lawall
2016-09-13 23:49 ` Rafael J. Wysocki
2016-09-14 2:03 ` Josh Triplett
2016-09-14 2:24 ` Joe Perches
2016-09-14 5:57 ` Julia Lawall
2016-09-14 6:27 ` Joe Perches
2016-09-14 6:35 ` Julia Lawall
2016-09-14 6:43 ` Joe Perches
2016-09-14 17:11 ` Alexandre Belloni [this message]
2016-09-15 16:33 ` Jonathan Cameron
2016-09-14 11:54 ` Greg KH
2016-09-14 14:23 ` Joe Perches
2016-09-14 14:32 ` Greg KH
2016-09-14 14:35 ` Julia Lawall
2016-09-14 14:39 ` Theodore Ts'o
2016-09-14 19:26 ` Julia Lawall
2016-09-14 14:51 ` Joe Perches
2016-09-14 19:30 ` Julia Lawall
2016-09-14 14:51 ` Joe Perches
2016-09-14 14:45 ` Guenter Roeck
2016-09-14 15:13 ` Joe Perches
2016-09-14 19:46 ` Guenter Roeck
2016-09-14 18:04 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160914170536.77fkhyiyikxc6jab@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=joe@perches.com \
--cc=ksummit-discuss@lists.linux-foundation.org \
--cc=ksummit-discuss@lists.linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox