From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 40763360 for ; Mon, 29 Aug 2016 19:06:31 +0000 (UTC) Received: from aserp1040.oracle.com (aserp1040.oracle.com [141.146.126.69]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id B4981232 for ; Mon, 29 Aug 2016 19:06:30 +0000 (UTC) Date: Mon, 29 Aug 2016 22:06:18 +0300 From: Dan Carpenter To: Joe Perches Message-ID: <20160829190618.GF4180@mwanda> References: <1472330452.26978.23.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1472330452.26978.23.camel@perches.com> Cc: ksummit-discuss@lists.linuxfoundation.org, Greg KH , Sasha Levin , LKML Subject: Re: [Ksummit-discuss] checkkpatch (in)sanity ? List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , I would like a couple changes which you know already: 1) Get rid of PREFER_ETHER_ADDR_COPY and similar because the people who send checkpatch.pl fixes aren't qualified to say when it's legal or not so they sometimes introduce bugs. 2) We could put some text in the output of --file output to say that if it's not a staging patch, then we don't care about just making checkpatch happy. So consider if it is a waste of maintainer time before sending. regards, dan carpenter