ksummit.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: "Levin, Alexander" <alexander.levin@verizon.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: "ksummit-discuss@lists.linuxfoundation.org"
	<ksummit-discuss@lists.linuxfoundation.org>,
	"Levin, Alexander" <alexander.levin@verizon.com>
Subject: Re: [Ksummit-discuss] Self nomination - Sasha Levin
Date: Fri, 26 Aug 2016 09:39:49 -0400	[thread overview]
Message-ID: <20160826133949.GB25341@sasha-lappy> (raw)
In-Reply-To: <20160826112635.GA27627@kroah.com>

On Fri, Aug 26, 2016 at 07:26:35AM -0400, Greg KH wrote:
> On Fri, Aug 26, 2016 at 12:46:51AM -0400, Levin, Alexander wrote:
> >    - Making checkpatch check for (some) of the stable kernel rules
> >    (and possibly recommend adding the stable@ tag in certain cases?).
> >      - Depends on: making checkpatch sane again.
> 
> This sounds interesting.  What do you mean by "sane"?  "sane" as in
> rewriting it so that someone who isn't a perl master can modify it?  Or
> "sane" as in "don't be so pedantic about things that don't matter"?

Both.

It actually came up during my talk: in theory we can enforce with checkpatch to produce proper stable@ tags with correct version/Fixes tagging to simplify our lives, but my claim was that the amount of actual people who use checkpatch is dropping due to the amount of warnings it spews that people just proceed to ignore.

The perl bit is also annoying, there's no way I can do what I suggested above myself.
 
> >    - Improving tagging for stable. The "version tag" option is broken
> >    and the "Fixes:" tag is always preferable, how do we get people to
> >    use that more often? (script it somehow?
> >    scripts/find-version-it-fixes ?).
> 
> Oh a script like that would be nice, but how would that work in reality?

The stable-deps script I have can find the commit dependencies you need to have to apply a give patch on top of that.

Since usually the broken fix is a dependency for the fix, we can figure out which commit we fix by looking at the dependency tree.

It's not going to be *perfect* (and since nothing is that's fine), but it could produce a very short list of possible options for a "Fixes:" tag.

-- 

Thanks,
Sasha

      parent reply	other threads:[~2016-08-26 13:40 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-26  4:46 Levin, Alexander
2016-08-26 11:26 ` Greg KH
2016-08-26 11:42   ` James Hogan
2016-08-26 11:50     ` James Hogan
2016-08-26 12:27       ` Jani Nikula
2016-08-26 12:39         ` James Hogan
2016-08-26 11:56     ` Greg KH
2016-08-26 12:17       ` James Hogan
2016-08-26 13:44       ` Levin, Alexander
2016-08-26 11:48   ` Julia Lawall
2016-08-26 11:55   ` Julia Lawall
2016-08-26 12:11     ` Greg KH
2016-08-26 13:51       ` Levin, Alexander
2016-08-26 13:55         ` Julia Lawall
2016-08-26 18:52           ` Levin, Alexander
2016-08-26 19:59             ` Julia Lawall
2016-08-26 12:08   ` Julia Lawall
2016-08-26 18:55     ` Levin, Alexander
2016-08-26 13:39   ` Levin, Alexander [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160826133949.GB25341@sasha-lappy \
    --to=alexander.levin@verizon.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=ksummit-discuss@lists.linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox