On Thu, Aug 04, 2016 at 12:14:14PM -0400, Steven Rostedt wrote: > Mark Brown wrote: > > I'm really happy we've got people engaging upstream. I'm happy if > > people fill in the extra information but really I'm way more interested > > in a clear changelog than in getting a Fixes tag, or in checking that > > the tags people are adding are accurate. > Having a clear change log is orthogonal to having a Fixes tag. Actually, > in my experience, change logs with Fixes tags tend to have clearer > explanations in the change log than those without. Because to get that > Fixes tag, one did some research to why the bug happened in the first > place. Yes, definitely - but equally the clear changelog will often have something to the effect of "we did more evaluation of the chip", "production versions of the chip have such and such a change" or whatever. > I mostly work in the core kernel, and any part of the kernel that has a > much larger area of use would greatly benefit from having clear change > logs as well as Fixes tags that point to regressions, or even if the > bug was there all along. It helps out in many areas besides just It's a sliding scale what should get the closest scruitiny and the most detailed changelogs and so on but hard rules affect everyone. > stable. As James mentions, it helps for regression tracking which is > something that people have been wanting to return. Indeed. More use for things like regression tracking would be a really good pull reason to get people engaged and motivate them to provide the information. > I found a bug in an old version of the kernel that I was using and when > I looked upstream, there was a fixes tag. Not only did I easily find > the proper fix, but it helped me see that the broken code was indeed in > the kernel I was playing with. That's something similar to having > stable releases, but it helps out any other users that are using older > kernels. To be clear I think it's great to have the information, I just don't think making it a requirement for every fix is going to have the desired result.