ksummit.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Josh Triplett <josh@joshtriplett.org>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Michal Marek <mmarek@suse.cz>,
	"ksummit-discuss@lists.linuxfoundation.org"
	<ksummit-discuss@lists.linuxfoundation.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Jiri Olsa <jolsa@kernel.org>,
	Arjan van de Ven <arjan@linux.intel.com>,
	Ingo Molnar <mingo@kernel.org>
Subject: Re: [Ksummit-discuss] [TECH TOPIC] tools/Makefile: Fix Many Many problems and inconsistencies
Date: Mon, 1 Aug 2016 22:02:33 -0700	[thread overview]
Message-ID: <20160802050232.nzgtuijqw46qopyr@x> (raw)
In-Reply-To: <0e76826b-6552-e880-42fc-17be0c5bf3fe@infradead.org>

On Mon, Aug 01, 2016 at 08:46:05PM -0700, Randy Dunlap wrote:
> and subdir Makefiles.
> 
> Examples:
> 
> Use/honor O=outputdir consistently instead of building in <kerneltree>/tools.
> (check/compare kernel commit bf35182ffcd00d8b36d56210ffdac110e5624d7d)
> 
> Honor MAKEFLAGS (well, they aren't even passed to tools/Makefile AFAICT.
> from an execution log:
> make LDFLAGS= MAKEFLAGS="" O=/local/lnx/kernel/lnx-47/TOOLS subdir=tools -C ../tools/ all
> 
> Use make's "findstring" correctly (see patch below)
> 
> There are lots of other problems unless I have just had too much too drink tonight,
> so here's the TECH TOPIC:
> 
> In a 1.5 hour code crunch session, get a bunch of interested people together to fix
> a lot of problems quickly.  Then I will be a guinea pig tester.  :)

Another pattern to look for: any instance of
ifeq ($(CONFIG_FOO),y)
where CONFIG_FOO is a tristate symbol should generally become
ifneq ($(CONFIG_FOO),n)

A higher-level item that I think would make a good topic: extracting
Kconfig into a library usable outside the kernel.  Several other
projects use a copied and hacked-up version of Kconfig.  I'd love to see
it more widely used as a build-time configuration system for more
projects, but not by forking it out of the kernel each time.  I've heard
kbuild/kconfig maintainers mention that they're interested in seeing
this done, but don't have the bandwidth to do it.

The thing that makes this a topic, rather than just a thing someone
needs to just do and submit a patch for, is determining the necessary
requirements from both the kernel and other projects, so that Kconfig
doesn't depend on the kernel but that the kernel build system doesn't
get any more complex to support that.

  parent reply	other threads:[~2016-08-02  5:02 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-02  3:46 Randy Dunlap
2016-08-02  4:53 ` Wangnan (F)
2016-08-03 19:00   ` Arnaldo Carvalho de Melo
2016-08-02  5:02 ` Josh Triplett [this message]
2016-08-02  7:31   ` Arnd Bergmann
2016-08-02  8:27     ` Josh Triplett
2016-08-02  8:41   ` Alexandre Belloni
2016-08-02  8:43     ` Josh Triplett
2016-09-04 21:15 ` Ben Hutchings
2016-09-06 14:57   ` Arnaldo Carvalho de Melo
2016-09-08  3:25     ` Bamvor Zhang Jian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160802050232.nzgtuijqw46qopyr@x \
    --to=josh@joshtriplett.org \
    --cc=arjan@linux.intel.com \
    --cc=jolsa@kernel.org \
    --cc=ksummit-discuss@lists.linuxfoundation.org \
    --cc=mingo@kernel.org \
    --cc=mmarek@suse.cz \
    --cc=rdunlap@infradead.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox