From: James Hogan <james.hogan@imgtec.com>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: Christoph Lameter <cl@linux.com>,
"ksummit-discuss@lists.linuxfoundation.org"
<ksummit-discuss@lists.linuxfoundation.org>
Subject: Re: [Ksummit-discuss] [ANNOUNCE] git-series: track changes to a patch series over time
Date: Fri, 29 Jul 2016 22:59:50 +0100 [thread overview]
Message-ID: <20160729215950.GB1302@jhogan-linux.le.imgtec.org> (raw)
In-Reply-To: <1469815046.2330.13.camel@HansenPartnership.com>
[-- Attachment #1: Type: text/plain, Size: 1895 bytes --]
On Fri, Jul 29, 2016 at 10:57:26AM -0700, James Bottomley wrote:
> On Fri, 2016-07-29 at 17:52 +0000, Bird, Timothy wrote:
> > I've been trying to convert to a pure git-based workflow, but for
> > some reason git rebase -I always seems to give me problems. It
> > always takes me much longer to just move some hunk from one
> > commit to another than it did in quilt using the patches and vi.
>
> I do this too, but I also work with the diff when moving hunks. What I
> do is:
>
> git checkout <removal commit>
> git show <removal commit> > tmp.diff
> vi tmp.diff so it only has the hunks I want to remove
> patch -p1 -R < ~/tmp.diff
another alternative:
git checkout -p HEAD~
and...
> git commit --amend -a
> git checkout <add commit>
> patch -p1 < ~/tmp.diff
> git commit --amend -a
git checkout -p <pre-rebase commit id> (assuming you're moving the hunk
further towards the head of the branch).
thats easy to do from a rebase -i, as you have all the commit ids right
there and can just add a line:
x git checkout -p <commit_id>
>
> It's a bit cumbersome, but you can script it. If there are better ways
> to do it, I'm interested.
I often find myself just splitting it up with rebase -i. I.e. just
duplicate the removal commit, and add "x git checkout -p HEAD~" in
between them. The second pick will end up just with the hunk you've
removed.
Then you can mark it as a fixup on a second run of rebase -i, or even on
the first run using commit --fixup and rebase --autosquash:
pick abc removal commit
x git checkout -p HEAD~
pick abc removal commit
x git commit --amend --fixup add_commit
For more complicated extractions where checkout -p HEAD~ gets confusing
or when you want to move a hunk backwards while avoiding nearby
conflicts, precede the removal commit with:
x git checkout -p <removal commit>
Cheers
James
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-07-29 21:59 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-29 7:50 Josh Triplett
2016-07-29 12:20 ` David Howells
2016-07-29 13:11 ` Josh Triplett
2016-08-04 22:46 ` Catalin Marinas
2016-08-04 23:07 ` Michael S. Tsirkin
2016-08-08 17:27 ` Catalin Marinas
2016-08-15 23:44 ` Michael S. Tsirkin
2016-08-04 23:46 ` Josh Triplett
2016-08-08 17:37 ` Catalin Marinas
2016-07-29 14:06 ` David Howells
2016-07-29 14:21 ` Christoph Lameter
2016-07-29 14:37 ` Josh Triplett
2016-07-29 15:00 ` Daniel Vetter
2016-07-29 15:18 ` Josh Triplett
2016-07-29 15:40 ` Daniel Vetter
2016-07-29 16:21 ` Josh Triplett
2016-07-29 16:31 ` Luis R. Rodriguez
2016-07-29 17:52 ` Bird, Timothy
2016-07-29 17:57 ` James Bottomley
2016-07-29 21:59 ` James Hogan [this message]
2016-07-30 2:55 ` Steven Rostedt
2016-07-29 20:13 ` David Howells
2016-07-30 5:02 ` Josh Triplett
2016-07-30 8:43 ` Arnd Bergmann
2016-08-04 12:44 ` Jani Nikula
2016-07-29 14:34 ` Josh Triplett
2016-07-29 14:37 ` David Howells
2016-07-29 14:56 ` Josh Triplett
2016-07-29 14:55 ` James Bottomley
2016-07-29 15:05 ` Josh Triplett
2016-08-09 0:10 ` Paul E. McKenney
2016-07-29 15:26 ` James Hogan
2016-08-04 23:52 ` Michael S. Tsirkin
2016-08-05 20:26 ` Josh Triplett
2016-08-15 13:20 ` James Hogan
2016-08-15 16:14 ` Josh Triplett
2016-08-15 23:42 ` Michael S. Tsirkin
2016-08-15 12:53 ` James Hogan
2016-08-15 16:34 ` Josh Triplett
2016-08-15 18:46 ` James Hogan
2016-08-15 21:35 ` Josh Triplett
2016-08-15 22:06 ` James Hogan
2016-08-15 23:59 ` Josh Triplett
2016-08-16 2:38 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160729215950.GB1302@jhogan-linux.le.imgtec.org \
--to=james.hogan@imgtec.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=cl@linux.com \
--cc=ksummit-discuss@lists.linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox