From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Hannes Reinecke <hare@suse.com>
Cc: ksummit-discuss@lists.linuxfoundation.org
Subject: Re: [Ksummit-discuss] [TECH TOPIC] asynchronous printk
Date: Tue, 19 Jul 2016 16:33:46 +0900 [thread overview]
Message-ID: <20160719073346.GB24189@swordfish> (raw)
In-Reply-To: <535ebaec-1653-3077-d17b-feb847fd51d2@suse.com>
On (07/19/16 08:17), Hannes Reinecke wrote:
[..]
> Yes. The main problem stems from the fact that printk has two different
> and conflicting use-cases:
> - Really urgent, 'I am about to die' messages. Which obviously need to
> be printed out as fast as possible.
> - Rather largish, information/logging 'what I always wanted to tell you'
> type of messages. These messages tend to be very large, but at the end
> it doesn't really matter _when_ they'll be printed as they are
> time-stamped anyway.
>
> For the first use-case you absolutely need a synchronous printk, but
> this is a complete killer for the second case.
> And OTOH having a separate thread is really the way to go for the second
> case, but an absolute no-go for the first.
>
> So I really wonder if it does make sense to lump both use-cases into one
> call, or whether it wouldn't be better to have two distinct calls
> for that (or, for the sake of argument, use KERN_EMERG to trigger
> synchronous printks).
yes, panic() must be in sync printk mode. but we do it a
bit differently: console_verbose() forces printk to switch
to sync mode.
so panic() goes like this:
panic()
{
console_verbose(); # switch to sync printk. forever.
bust_spinlocks();
pr_emerg("Kernel panic - not syncing...");
....
debug_locks_off();
console_flush_on_panic(); # flushes kernel log_bug in
# sync mode
// the rest of panic()
}
-ss
next prev parent reply other threads:[~2016-07-19 7:33 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-19 3:47 Sergey Senozhatsky
2016-07-19 3:56 ` Viresh Kumar
2016-07-19 6:17 ` Hannes Reinecke
2016-07-19 6:49 ` Josh Triplett
2016-07-19 7:02 ` Hannes Reinecke
2016-07-19 7:11 ` Geert Uytterhoeven
2016-07-20 6:02 ` Jan Kara
2016-07-20 22:54 ` Josh Triplett
2016-07-21 0:46 ` Sergey Senozhatsky
2016-07-21 1:12 ` Josh Triplett
2016-07-19 7:33 ` Sergey Senozhatsky [this message]
2016-07-19 7:38 ` Hannes Reinecke
2016-07-19 7:46 ` Sergey Senozhatsky
2016-07-19 8:02 ` Hannes Reinecke
2016-07-19 8:23 ` Sergey Senozhatsky
2016-07-21 10:36 ` David Woodhouse
2016-07-21 12:31 ` Jan Kara
2016-07-28 2:55 ` Steven Rostedt
2016-07-20 6:09 ` Jan Kara
2016-07-19 7:46 ` Christian Borntraeger
2016-07-19 7:53 ` Christian Borntraeger
2016-07-19 13:55 ` Jan Kara
2016-07-28 2:59 ` Steven Rostedt
2016-07-28 4:12 ` Sergey Senozhatsky
2016-07-28 13:02 ` Steven Rostedt
2016-07-20 3:35 ` Wangnan (F)
2016-07-21 1:16 ` Andy Lutomirski
2016-07-21 1:52 ` Wangnan (F)
2016-07-21 5:59 ` Hannes Reinecke
2016-07-21 10:31 ` David Woodhouse
2016-07-21 11:19 ` Josh Triplett
2016-07-21 11:59 ` David Woodhouse
2016-07-21 14:21 ` Josh Triplett
2016-07-21 14:40 ` David Woodhouse
2016-07-28 3:05 ` Steven Rostedt
2016-08-02 11:59 ` Petr Mladek
2016-07-21 15:05 ` Andy Lutomirski
2016-07-26 14:40 ` David Woodhouse
2016-07-26 15:44 ` Benjamin Herrenschmidt
2016-07-26 21:00 ` Andy Lutomirski
2016-07-27 0:03 ` David Woodhouse
2016-07-27 1:16 ` Sergey Senozhatsky
2016-07-21 10:28 ` David Woodhouse
2016-07-19 14:45 ` James Bottomley
2016-07-19 14:55 ` Sergey Senozhatsky
2016-07-19 17:58 ` James Bottomley
2016-07-19 18:24 ` Viresh Kumar
2016-07-20 2:08 ` Sergey Senozhatsky
2016-07-20 6:14 ` Jan Kara
2016-09-21 4:41 ` Sergey Senozhatsky
2016-10-31 6:54 ` Sergey Senozhatsky
2016-10-31 13:56 ` Theodore Ts'o
2016-10-31 13:59 ` Jiri Kosina
2016-10-31 14:56 ` [Ksummit-discuss] [TECH TOPIC] printk considered harmful (was: [TECH TOPIC] asynchronous printk) Sergey Senozhatsky
2016-10-31 16:18 ` Theodore Ts'o
2016-10-31 18:21 ` Sergey Senozhatsky
2016-10-31 18:26 ` [Ksummit-discuss] [TECH TOPIC] printk considered harmful Hannes Reinecke
2016-10-31 20:28 ` [Ksummit-discuss] [TECH TOPIC] printk considered harmful (was: [TECH TOPIC] asynchronous printk) Jan Kara
2016-11-01 12:27 ` [Ksummit-discuss] [TECH TOPIC] printk considered harmful Hannes Reinecke
2016-11-01 17:50 ` [Ksummit-discuss] [TECH TOPIC] printk considered harmful (was: [TECH TOPIC] asynchronous printk) Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160719073346.GB24189@swordfish \
--to=sergey.senozhatsky.work@gmail.com \
--cc=hare@suse.com \
--cc=ksummit-discuss@lists.linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox