From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Wed, 26 Aug 2015 15:09:11 -0500 From: Greg Kroah-Hartman To: Sudip Mukherjee Message-ID: <20150826200911.GA7269@kroah.com> References: <20150723154014.GD11162@sirena.org.uk> <55B7FD82.8010806@sonymobile.com> <55B82222.3010409@samsung.com> <20150729074011.GB12557@amd> <55DCBB21.8070009@sonymobile.com> <55DD14C3.8090707@samsung.com> <20150826125630.GH3684@io.lakedaemon.net> <20150826135835.GA13900@sudip-pc> <20150826145129.GI3684@io.lakedaemon.net> <20150826171331.GA1815@fool> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150826171331.GA1815@fool> Cc: Jason Cooper , "ksummit-discuss@lists.linuxfoundation.org" , Pavel Machek , "kyungmin.park@samsung.com" , John Stultz , =?iso-8859-1?Q?Andersson=2C_Bj=F6rn?= Subject: Re: [Ksummit-discuss] [CORE TOPIC] Mainline kernel on a cellphone List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, Aug 26, 2015 at 10:43:31PM +0530, Sudip Mukherjee wrote: > On Wed, Aug 26, 2015 at 02:51:29PM +0000, Jason Cooper wrote: > > Hi Sudip, > > > > On Wed, Aug 26, 2015 at 07:28:35PM +0530, Sudip Mukherjee wrote: > > > On Wed, Aug 26, 2015 at 12:56:30PM +0000, Jason Cooper wrote: > > > > On Wed, Aug 26, 2015 at 10:22:11AM +0900, Krzysztof Kozlowski wrote: > > > > > Mali GPU drivers are an interesting case: > > > > ... > > > > > 4. Their coding style is so different that I can't imagine mainlining > > > > > them into staging area... Recently I was digging into Mali400 and it was > > > > > literally hurting my eyes to see that coding style. It's like opposite > > > > > of kernel. > > > > > > > > iirc, gregkh's requirement for staging/ is that it compile. Nothing > > > > more. > > > > > > Yes. But Greg will also say that we should be modifying the code with > > > the ultimate goal of moving it out of staging into the main part of the > > > kernel. And if all of us know that it can not be merged into the main part > > > because of closed userspace then will Greg accept it? > > > > Well, this seems to me to be a case of chicken-and-the-egg, which came > > first? fwiw, I think there's benefit in putting the driver in staging/ > > to see if it ignites development efforts on the userspace side. If it > > doesn't, I know Greg isn't shy about removing drivers from staging. ;-) > Adding Greg in the To: list for his comments. > > Hi Greg, > Incase you have not seen the previous mails in the thread, we were > discussing if mali driver code can be added to staging. Many benefits, > but the problem is that the userspace is closed and unless we have an > open userspace this cannot be merged with the main part of the kernel. staging is not for dumping crap that the owners don't want to do the work to get it merged "properly". So I will not take DRM drivers in staging that violate the existing DRM rules of requiring an open userspace as that would mean I would be adding code that can never be merged out of the staging tree. sorry, go kick the Mali authors to do this correctly. They know what they have to do, their management just doesn't want to let them do it. good luck, greg k-h