From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id DBF8E407 for ; Sat, 1 Aug 2015 22:16:14 +0000 (UTC) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 4E6448B for ; Sat, 1 Aug 2015 22:16:13 +0000 (UTC) Date: Sun, 2 Aug 2015 08:16:00 +1000 From: NeilBrown To: Geert Uytterhoeven Message-ID: <20150802081600.73d54e4e@noble> In-Reply-To: References: <20150708114011.3a1f1861@noble> <2879113.fraeuJIr2M@avalon> <20150709193718.GD9169@vmdeb7> <20150710143641.GW4341@mwanda> <20150710160714.GL111846@vmdeb7> <20150710222351.GA28632@kroah.com> <20150711000034.GU111846@vmdeb7> <20150711001348.GA30675@kroah.com> <20150711055441.GA6316@sudip-PC> <20150715212043.775be5d2@gandalf.local.home> <20150716132551.GH4039@sirena.org.uk> <20150716094720.2bf9f5ac@gandalf.local.home> <55A7C7FE.6000604@sonymobile.com> <20150716094125.16cdda73@lwn.net> <55A7D73F.4020105@sonymobile.com> <20150716121620.65ce6daa@gandalf.local.home> <55A7DAD8.2080902@sonymobile.com> <20150716125216.0d457104@gandalf.local.home> <55BB7397.3090407@atmel.com> <1438352566.2179.4.camel@HansenPartnership.com> <1438453195.2182.16.camel@HansenPartnership.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: James Bottomley , Dan Carpenter , Jason Cooper , "ksummit-discuss@lists.linuxfoundation.org" Subject: Re: [Ksummit-discuss] [CORE TOPIC] Recruitment (Reviewers, Testers, Maintainers, Hobbyists) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Sat, 1 Aug 2015 20:42:29 +0200 Geert Uytterhoeven wrote: > On Sat, Aug 1, 2015 at 8:19 PM, James Bottomley > wrote: > > On Sat, 2015-08-01 at 20:16 +0200, Geert Uytterhoeven wrote: > >> On Fri, Jul 31, 2015 at 4:22 PM, James Bottomley > >> wrote: > >> > On Fri, 2015-07-31 at 15:09 +0200, Nicolas Ferre wrote: > >> >> Le me just react on the "no attachment" statement: > > >> Adding inline review comments is something different. > > > > Every mail tool I know can quote from attachments. One of the side > > benefits is that reply-all doesn't, so you actually have to quote the > > section you're commenting on instead of, say, doing reply-all to a 1,000 > > line patch with a single comment on line 745, which is a real pain for a > > maintainer ... > > So I have to manually _add_ all sections I want to comment on (and add "> " > markers), instead of _deleting_ all sections I don't want to comment on? > > Looks suitable for patches which require a single comment only... > (Which is usually not the case for patches sent as attachments ;-) > Claws-mail doesn't make it easy to reply to attachments - you have to use the clumsy "copy/paste/add '>'" that you describe. However asserting that other people should follow a particular work flow because my tools aren't very good does not sound like a convincing argument to me. If my tools don't work with a workflow that is prima-facie reasonable, then it is my tools that are at fault and I should fix them, not ask someone else to change their workflow. NeilBrown