From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 23B9B40C for ; Fri, 17 Jul 2015 19:30:21 +0000 (UTC) Received: from mx0a-00082601.pphosted.com (mx0a-00082601.pphosted.com [67.231.145.42]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id A0413AC for ; Fri, 17 Jul 2015 19:30:20 +0000 (UTC) Date: Fri, 17 Jul 2015 15:30:13 -0400 From: Chris Mason To: Steven Rostedt Message-ID: <20150717193013.GB8274@ret.masoncoding.com> References: <20150715212043.775be5d2@gandalf.local.home> <20150716132551.GH4039@sirena.org.uk> <20150716094720.2bf9f5ac@gandalf.local.home> <55A7C7FE.6000604@sonymobile.com> <20150716094125.16cdda73@lwn.net> <1437063875.18768.59.camel@HansenPartnership.com> <20150717101151.5d5bc86d@lwn.net> <20150717133712.42c82add@gandalf.local.home> <22243b88-029f-4560-9e13-0b7001ed14ec@email.android.com> <20150717135313.6b917e1a@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20150717135313.6b917e1a@gandalf.local.home> Cc: James Bottomley , Dan Carpenter , Jason Cooper , "ksummit-discuss@lists.linuxfoundation.org" Subject: Re: [Ksummit-discuss] [CORE TOPIC] Recruitment (Reviewers, Testers, Maintainers, Hobbyists) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Fri, Jul 17, 2015 at 01:53:13PM -0400, Steven Rostedt wrote: > On Fri, 17 Jul 2015 20:43:12 +0300 > James Bottomley wrote: > > > > >--- Some Maintainer's prefer these styles --- > > > > > > These are some extra styles that maintainers prefer. Some are strict > > > about these, others may not care. It doesn't hurt to add them. > > > > > > > > > > If you do that, and I get 500 coccinelle generated patches for SCSI switching the includes to reverse Christmas tree one file at a time, I'm afraid I'll have to shoot you. > > I'll remember to wear my bullet proof vest coming to KS. > > Should stress that just some people prefer them. Heck, we can teach > checkpatch.pl to look at what file is being modified and see what > formats the maintainer of the file wants. :-) We're way off in the weeds here, and whenever this topic comes up, we end up focusing on the minor annoyances that come from submitting new code. Small variations in coding style, function naming and general methods for working with a maintainer are sure to vary. Looking at Jon's statistics, we don't have a problem bringing new people into the kernel. What can we do to help the new people be more productive? My own feeling is feedback, testing and documentation are more important than 100% consistency between maintainers. I love Greg's swag idea, I'm sure more than one LF member would be willing to help sponsor such a thing. -chris