From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id B1075BB6 for ; Tue, 14 Jul 2015 04:38:15 +0000 (UTC) Received: from mail-pa0-f45.google.com (mail-pa0-f45.google.com [209.85.220.45]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id B149A32 for ; Tue, 14 Jul 2015 04:38:14 +0000 (UTC) Received: by pactm7 with SMTP id tm7so219044255pac.2 for ; Mon, 13 Jul 2015 21:38:14 -0700 (PDT) Date: Tue, 14 Jul 2015 10:08:03 +0530 From: Sudip Mukherjee To: Dan Carpenter Message-ID: <20150714043803.GA3290@sudip-PC> References: <20150708080032.CE89E4306F@saturn.retrosnub.co.uk> <20150708145315.29030a75@gandalf.local.home> <20150710181409.GA30145@treble.redhat.com> <1436576450.27924.59.camel@stgolabs.net> <20150712034824.GA4236@treble.hsd1.ky.comcast.net> <20150712052317.GB15346@x> <20150712122823.GA4366@treble.redhat.com> <20150713140113.GB4341@mwanda> <20150713143331.GA21079@quack.suse.cz> <20150713162439.GI4289@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150713162439.GI4289@mwanda> Cc: James Bottomley , jic23@jic23.retrosnub.co.uk, Jason Cooper , ksummit-discuss@lists.linuxfoundation.org Subject: Re: [Ksummit-discuss] [CORE TOPIC] Recruitment (Reviewers, Testers, Maintainers, Hobbyists) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mon, Jul 13, 2015 at 07:28:25PM +0300, Dan Carpenter wrote: > On Mon, Jul 13, 2015 at 04:33:31PM +0200, Jan Kara wrote: > > On Mon 13-07-15 17:20:47, Dan Carpenter wrote: > > > On Sun, Jul 12, 2015 at 07:28:23AM -0500, Josh Poimboeuf wrote: > > This happened hours ago in staging. Someone sent a buggy patch and > reviewers spotted the bug but no one got credit. > > http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2015-July/072662.html > http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2015-July/072668.html > > Imagine how special Patrick would feel if we gave him a nice > "With-fix-from: Patrick Farrell " tag. :) Also the other > rule would be that only the first person to report the bug gets the > credit (Sorry, Sudip). Doesn't matter. I am a volunteer and contributing here is not part of my dayjob. I do it because I like doing it. >The next version of the patch had a process > problem which Sudip noticed as well but that still doesn't earn a > with-fix-from tag. Then will the first reviewer always get the credit? Suppose a hypothetial situation where v1 is just having a bug like the one you mentioned, reviewer X points that out so he gets "With-fix-from:", but v2 has a more serious problem and results in build failure and reviewer Y points that out and v3 is the final patch that is accepted. So now who will get "With-fix-from:" ? regards sudip