From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id B5B6DA04 for ; Fri, 10 Jul 2015 22:49:38 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 899A6FD for ; Fri, 10 Jul 2015 22:49:37 +0000 (UTC) Date: Fri, 10 Jul 2015 15:49:29 -0700 From: Darren Hart To: Roberto Tyley Message-ID: <20150710224929.GO111846@vmdeb7> References: <2879113.fraeuJIr2M@avalon> <20150709193718.GD9169@vmdeb7> <20150710114409.638582c0@gandalf.local.home> <20150710.193255.181692772319686216.chriscool@tuxfamily.org> <20150710174940.GN111846@vmdeb7> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Cc: Roberto Tyley , ksummit-discuss@lists.linuxfoundation.org, jason@lakedaemon.net Subject: Re: [Ksummit-discuss] [CORE TOPIC] Recruitment (Reviewers, Testers, Maintainers, Hobbyists) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Fri, Jul 10, 2015 at 08:35:59PM +0100, Roberto Tyley wrote: Hi Roberto, Thanks for chiming in. > It would be great to turn on submitGit for development of the Linux > Kernel. Just to clarify, submitGit is a bridge for sending GitHub pull > requests on https://github.com/git/git to git@vger.kernel.org as > correctly formatted emails While there is value there and would help a lot of people, given the popularity of git-hub, I think we're looking for something more generic. I'd prefer a web-form hosted on kernel.org that could accept a raw patch, or a git URL and tag or branch from any reposiory (github or otherwise), and submit the patch after performing a number of validation checks before ever sending to the list. I understand this maybe isn't an extension of submitGit, but the concept of submitGit is interesting from a precedence perspective. > I've never submitted a patch to the kernel, but I understand there are > many development trees and corresponding maintainers/mailing lists. It > would be an interesting task to teach submitGit _where_ a patch should > go - and we would need GitHub repos which mirrored the maintainer > trees in order for people to open good pull requests against them (I'm > assuming it would be wrong for people to just open pull requests > against https://github.com/torvalds/linux/). > > This script looks interesting: > https://github.com/torvalds/linux/blob/master/scripts/get_maintainer.pl Yes, this should be used to identify lists and maintainers who should be Cc'd. > I'd be interested to hear if anyone would like to try out submitGit > for the kernel, and has any further advice. > > Roberto > Thanks, Darren P.S. I don't know if your top posting was intentional (very clever) or accidental (case in point), but either way it's dripping with irony. ;-) > > > On 10 July 2015 at 18:49, Darren Hart wrote: > > On Fri, Jul 10, 2015 at 07:32:55PM +0200, Christian Couder wrote: > >> From: Steven Rostedt > >> Subject: Re: [Ksummit-discuss] [CORE TOPIC] Recruitment (Reviewers, Testers, Maintainers, Hobbyists) > >> Date: Fri, 10 Jul 2015 11:44:09 -0400 > >> > >> > On Thu, 9 Jul 2015 12:37:18 -0700 > >> > Darren Hart wrote: > >> > > >> >> I've come to believe that this is one of many side effects of our dependency on > >> >> a completely free form mechanism for the management of our patches, a mechanism > >> >> which is becoming harder and harder to setup "correctly" with modern tooling > >> >> (since the industry is killing "real email"). > >> >> > >> >> I spend a highly disproportionate amount of my time, relative to measurable > >> >> quality impact to the kernel, going over the nuances of submitting patches. > >> >> > >> >> 1) Must have a complete commit message > >> >> 2) DCO goes above the --- > >> >> 3) Include a patch changelog, do so below --- > >> >> 4) Cc maintainers :-) > >> >> 5) Checkpatch... checkpatch... checkpatch... > >> > > >> > Ug, don't emphasize checkpatch. I see people making patches uglier due > >> > to it. I have an old version of checkpatch that I sometimes run, but > >> > the new version, IMHO, has more noise than signal. > >> > > >> >> 6) Compiler warnings > >> >> 7) CodingStyle :-) > >> >> 8) Use ascii or utf8 character encodings > >> >> > >> > > >> > > >> >> Looking forward a bit, I would love to see some tooling in place for people to > >> >> submit patches either via a web form (which eliminates all the email tooling for > >> >> submitting patches - which is where the formatting is especially critical) or > >> >> through one of the more managed git systems, like gerrit, etc. > >> > > >> > You mean like a web page that has a bunch of entries (like submitting a > >> > paper to a LF conference), and you need to fill out. > >> > >> To send patch emails created from git repos on GitHub to the Git > >> mailing list, there is now submitGit: > >> > >> https://submitgit.herokuapp.com/ > >> https://github.com/rtyley/submitgit > >> > >> Maybe Roberto, its author (cced), could be convince to do something > >> for the kernel? > > > > Something along those lines would be nice, yes. I think a lot of people would > > find something like this which enforces the "mechanical" rules to be very > > useful. > > > > -- > > Darren Hart > > Intel Open Source Technology Center > -- Darren Hart Intel Open Source Technology Center