From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 4DBDFBCB for ; Fri, 10 Jul 2015 00:14:24 +0000 (UTC) Received: from imap.thunk.org (imap.thunk.org [74.207.234.97]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id E3331EE for ; Fri, 10 Jul 2015 00:14:23 +0000 (UTC) Date: Thu, 9 Jul 2015 20:14:11 -0400 From: Theodore Ts'o To: Dmitry Torokhov Message-ID: <20150710001411.GJ9417@thunk.org> References: <201507080121.41463.PeterHuewe@gmx.de> <1481488.5WJFbB0Dlm@vostro.rjw.lan> <1436341028.2136.14.camel@HansenPartnership.com> <20150708080032.CE89E4306F@saturn.retrosnub.co.uk> <20150708145315.29030a75@gandalf.local.home> <20150709193951.GE9169@vmdeb7> <20150709202152.GE1237@dtor-ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150709202152.GE1237@dtor-ws> Cc: James Bottomley , Jason Cooper , ksummit-discuss@lists.linuxfoundation.org, jic23@jic23.retrosnub.co.uk Subject: Re: [Ksummit-discuss] [CORE TOPIC] Recruitment (Reviewers, Testers, Maintainers, Hobbyists) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thu, Jul 09, 2015 at 01:21:52PM -0700, Dmitry Torokhov wrote: > > No, that is not always true. If I see a naked "reviewed-by" from a > person who's been working on the subsystem quite a bit and shown a good > judgement it is enough for me. I do not need them to find something to > nitpick over so that there is "meat" to the review. Absolutely. If I'm looking at a patch for ext4, and I see a bare Reviewed-by: from Jan Kara, I treat that very differently compared to a Reviewed-by: coming from someone like Nick Krause. The challenge is if we are using a scheme that uses some kind of automated counting of Reviewed-by lines, how do we make the system smart enough so it counts the former, but not the latter? Or worse, *encourages* more of the latter, which just adds more noise which actually increases the load on Maintainers, not decreases. (Which is also my objection to people sending patches generated from "checkpatch --file" runs. Maybe it's fine in for staging code, but for other subsystems, it basically just means there are more patches that require review by someone clueful --- since sometimes "cleanup" patches from trolls actually introduce bugs.) - Ted