Re: [Ksummit-discuss] [CORE TOPIC] Recruitment (Reviewers, Testers, Maintainers, Hobbyists)

[Mark Brown <broonie@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1307 bytes --]

On Thu, Jul 09, 2015 at 12:47:34PM -0700, Darren Hart wrote:
> On Thu, Jul 09, 2015 at 12:23:20PM -0700, Guenter Roeck wrote:

> > It looks like we have yet another set of diverging maintainer expectations.
> > Some maintainers will expect me to provide an extra comment, which I'll
> > have to phrase carefully to avoid it being misinterpreted as "I just
> > glanced at the code and didn't find an obvious issue with it".
> > Others will get annoyed at me providing the extra comment.

I guess I'm one of those you're thinking about here - annoyed is very
strong, it's definitely not an active problem.  If it's saying something
out of the ordinary then it's adding value but a lot of patches really
are just pretty routine.

> Why would a couple lines of context be any harder to deal with than all the
> meta-data that comes along with an email including a Reviewed-by?

Personally it's the difference between one line of new text that can be
read by pattern matching and new text which requires looking at the
actual words.  It's not the end of the world (and I'd go so far as to
say it's actually a good thing if it's adding something) but in cases
where I've got a big stack of things I've already looked at where I'm
waiting for acks it does help make things a bit smoother.  

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]