From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 7BA2DACC for ; Thu, 9 Jul 2015 19:40:00 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 232F8F1 for ; Thu, 9 Jul 2015 19:40:00 +0000 (UTC) Date: Thu, 9 Jul 2015 12:39:51 -0700 From: Darren Hart To: Steven Rostedt Message-ID: <20150709193951.GE9169@vmdeb7> References: <201507080121.41463.PeterHuewe@gmx.de> <1481488.5WJFbB0Dlm@vostro.rjw.lan> <1436341028.2136.14.camel@HansenPartnership.com> <20150708080032.CE89E4306F@saturn.retrosnub.co.uk> <20150708145315.29030a75@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150708145315.29030a75@gandalf.local.home> Cc: James Bottomley , jic23@jic23.retrosnub.co.uk, Jason Cooper , ksummit-discuss@lists.linuxfoundation.org Subject: Re: [Ksummit-discuss] [CORE TOPIC] Recruitment (Reviewers, Testers, Maintainers, Hobbyists) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, Jul 08, 2015 at 02:53:15PM -0400, Steven Rostedt wrote: > On Wed, 08 Jul 2015 09:00:32 +0100 > jic23@jic23.retrosnub.co.uk wrote: > > > > > We can alter that somewhat. We used to run a Maintainers lottery for > > > the kernel summit ... we could instead offer places based on the number > > > of Reviewed-by: tags ... we have all the machinery to calculate that. I > > > know an invitation to the kernel summit isn't a huge incentive, but it's > > > a useful one. > > > > Sounds like a good idea to me, though it would only effect a tiny > > percentage of our reviewers. I suppose publishing a short list of the top > > n% of reviewers from which the lottery runs might give some > > recognition. > > > > I personally don't trust a Reviewed-by tag much, as I sometimes see > them appear without any comments. > > I was thinking of writing a perl script that would read my LKML archive > and somewhat intelligently looking at people who replied to patches, > that also has snippets of the patch in the reply, and counting them. I > think that would be a more accurate use of real reviewers than just the > Reviewed-by tag. Agreed. Unless there is commentary accompanying the review, it doesn't add a lot. While the nod of approval builds incremental confidence, the true measure of a review is a resulting change to the patch for the better. Of course, a good review takes the same amount of time regardless of if a change is required. -- Darren Hart Intel Open Source Technology Center