Re: [Ksummit-discuss] [CORE TOPIC] Recruitment (Reviewers, Testers, Maintainers, Hobbyists)

[Steven Rostedt <rostedt@goodmis.org>]

On Thu, 9 Jul 2015 13:21:52 -0700
Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote:
 
> > Agreed. Unless there is commentary accompanying the review, it doesn't add a
> > lot.
> 
> No, that is not always true. If I see a naked "reviewed-by" from a
> person who's been working on the subsystem quite a bit and shown a good
> judgement it is enough for me. I do not need them to find something to
> nitpick over so that there is "meat" to the review.


And this is where the problem lies. Every review by tag is different,
and it really matters from who it's from. I've had people send me a
"Reviewed-by" tag that I had no idea who it is from, and with no
commentary. That to me is worthless.

But I've sent patches out and have asked people like Masami Hiramatsu
to review it, and if he returns just a "Reviewed-by" with no
commentary, I take that as a positive, and that he didn't find anything
wrong with what I wrote. And I gladly add that tag as it has meaning to
me.

It really does come down to the maintainer. They should only add a
Reviewed-by tag from someone they trust, or from someone that has given
them constructive criticisms for the patch. I really don't know how
strict maintainers of other subsystems are with regard to adding those
tags.

I personally don't add that tag unless I have done an extensive review
of the patch. I don't want some stupid bug come back to a patch that
has my Reviewed-by tag on it. But I have reviewed lots of patches where
I haven't put enough effort into adding a RB tag. Perhaps I should just
add "Looks-fine-to-me-by:" tag, stating I did a light review but not a
thorough one. ;-)

-- Steve