From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTP id F05E59CB for ; Sat, 31 May 2014 01:09:04 +0000 (UTC) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 6414520215 for ; Sat, 31 May 2014 01:09:03 +0000 (UTC) Date: Fri, 30 May 2014 16:40:03 -0700 From: Greg KH To: "Paul E. McKenney" Message-ID: <20140530234003.GG25854@kroah.com> References: <20140528163902.GA5099@sirena.org.uk> <1401295862.13546.109.camel@dhcp-9-2-203-236.watson.ibm.com> <20140528173553.GE5099@sirena.org.uk> <3908561D78D1C84285E8C5FCA982C28F328205B1@ORSMSX114.amr.corp.intel.com> <20140528183825.GA21477@sirena.org.uk> <5386FDAB.3010106@huawei.com> <20140529174122.GC7889@kroah.com> <20140530172858.GA16343@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140530172858.GA16343@linux.vnet.ibm.com> Cc: James Bottomley , Dan Carpenter , Mark Brown , "ksummit-discuss@lists.linuxfoundation.org" Subject: Re: [Ksummit-discuss] [TOPIC] Encouraging more reviewers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Fri, May 30, 2014 at 10:28:58AM -0700, Paul E. McKenney wrote: > On Thu, May 29, 2014 at 10:41:22AM -0700, Greg KH wrote: > > On Thu, May 29, 2014 at 05:28:11PM +0800, Li Zefan wrote: > > > On 2014/5/29 5:32, Thomas Gleixner wrote: > > > > On Wed, 28 May 2014, Mark Brown wrote: > > > > > > > >> On Wed, May 28, 2014 at 05:44:41PM +0000, Luck, Tony wrote: > > > >> > > > >>>> There's a world of difference between thanking people for review and a > > > >>>> detailed account of all the changes made in every single iteration of > > > >>>> the review. > > > >> > > > >>> This is already covered in Documentation/SubmittingPatches. Quoting > > > >>> lines 585-592 (see last sentence): > > > >> > > > >> Right, but Daniel is proposing lifting that above the --- and including > > > >> it in git. > > > > > > > > What you really want is: > > > > > > > > Link: https://lkml.kernel.org/r/MESSAGE_ID_OF_PATCH > > > > > > > > It's way more useful than any of the v1-n writeups, which are most of > > > > the time just a completely waste of electrons. Even if written well, > > > > without the actual review context they are pretty pointless. > > > > > > > > > > A QA asked me about kernel development process. One of his question is, > > > he found some valuable information in the discussion of the patch often > > > won't be added to the changelog, so providing the commit how to find > > > the discussion? > > > > A research group has created a tool that takes a given git commit, finds > > the mailing list discussion for that patch. It was posted to lkml 6 or > > so months ago, you should point them at that tool if they want to do > > this. > > This one? https://lkml.org/lkml/2014/3/11/2 Yes, that's it. greg k-h