From: Christian Couder <chriscool@tuxfamily.org>
To: johan@herland.net
Cc: gitster@pobox.com, jason@lakedaemon.net,
ksummit-discuss@lists.linuxfoundation.org
Subject: Re: [Ksummit-discuss] [TOPIC] Metadata addendum to git commit
Date: Thu, 22 May 2014 08:52:55 +0200 (CEST) [thread overview]
Message-ID: <20140522.085255.1219334027984029922.chriscool@tuxfamily.org> (raw)
In-Reply-To: <CALKQrgfK7xosKvDHBS3HPoHtjZY09mt04MSbVDpEFhOcy8UqQg@mail.gmail.com>
From: Johan Herland <johan@herland.net>
> On Thu, May 22, 2014 at 7:58 AM, Takashi Iwai <tiwai@suse.de> wrote:
>>> From: Junio C Hamano <gitster@pobox.com>:
>>> A good way forward to solve Iwai-san's original issue might be
>>>
>>> * Establish the "Fixes:" mentioned above as a standard practice.
>>> Polishing Christian's interpret-trailers tool might be a good way
>>> to encourage developers to do so.
>>>
>>> * Have an easy way for developers to scan incoming commits for
>>> these "Fixes:" footer, and record the reverse mapping locally, so
>>> that we can go from a commit whose brokenness is discovered later
>>> to the commit that fixes its breakage efficiently. "notes" may
>>> be a good mechanism to implement this mapping, and we do not have
>>> to worry about sharing the notes trees among developers.
>>>
>>> * The information is visible with "log --show-notes" if it is
>>> stored in local notes. When an earlier commit that was later
>>> found to be broken is shown, the note that points at the commit
>>> that fixes it will be shown.
>>>
>>> * Teach "bisect" to also take notice of this information, and
>>> temporarily cherry-pick while testing commits with fixes that
>>> were discovered later, in a way similar to what was suggested by
>>> Jiri Kosina in an earlier message.
>>
>> These sound like a good plan, indeed.
>>
>> But, one missing, and maybe often happening thing is: people forget to
>> tag at the right time. In the scenario above, if a maintainer forgets
>> to add Fixes: tag in the fix commit, it's all gone?
>
> Yes, unless you add it (using git-notes) as an annotation to the fix
> commit, but then you're back to the (perceived) problem of sharing
> those notes.
By the way, I wonder if it might be possible to have signed "notes" or
signed "replace"?
Best,
Christian.
next prev parent reply other threads:[~2014-05-22 6:52 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-13 13:25 Takashi Iwai
2014-05-13 23:23 ` NeilBrown
2014-05-13 23:29 ` Jiri Kosina
2014-05-13 23:49 ` NeilBrown
2014-05-14 1:40 ` Li Zefan
2014-05-16 3:07 ` Jason Cooper
2014-05-16 5:12 ` Christian Couder
2014-05-16 9:24 ` Li Zefan
2014-05-16 9:33 ` Takashi Iwai
2014-05-18 19:23 ` Christian Couder
2014-05-18 22:12 ` Jason Cooper
2014-05-19 6:34 ` Christian Couder
2014-05-19 13:29 ` Takashi Iwai
2014-05-20 6:37 ` Christian Couder
2014-05-20 7:06 ` Takashi Iwai
2014-05-21 5:36 ` Christian Couder
2014-05-22 4:49 ` Christian Couder
2014-05-22 5:58 ` Takashi Iwai
2014-05-22 6:28 ` Johan Herland
2014-05-22 6:52 ` Christian Couder [this message]
2014-05-22 7:29 ` Johan Herland
2014-05-22 7:45 ` Takashi Iwai
2014-05-22 7:49 ` Geert Uytterhoeven
2014-05-22 8:03 ` Takashi Iwai
2014-05-22 15:51 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140522.085255.1219334027984029922.chriscool@tuxfamily.org \
--to=chriscool@tuxfamily.org \
--cc=gitster@pobox.com \
--cc=jason@lakedaemon.net \
--cc=johan@herland.net \
--cc=ksummit-discuss@lists.linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox