From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 3FDD78D9 for ; Sat, 3 Sep 2016 14:11:17 +0000 (UTC) Received: from ozlabs.org (ozlabs.org [103.22.144.67]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 9084A248 for ; Sat, 3 Sep 2016 14:11:16 +0000 (UTC) In-Reply-To: References: <20160902104619.GD9355@localhost> <7359509.5sppVSLXcK@wuerfel> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 From: Michael Ellerman Date: Sun, 04 Sep 2016 00:02:04 +1000 To: Linus Torvalds , Arnd Bergmann , Michael Ellerman , Benjamin Herrenschmidt Message-ID: <1B7B3351-2578-4096-8B55-B623E606D2EC@ellerman.id.au> Cc: ksummit-discuss@lists.linuxfoundation.org, "Nikula, Jani" , Dave Airlie , Grant Likely , ppc-dev Subject: Re: [Ksummit-discuss] [CORE TOPIC] (group) maintainership models List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 3 September 2016 06:26:08 GMT+10:00, Linus Torvalds wrote: >On Fri, Sep 2, 2016 at 1:06 PM, Arnd Bergmann wrote: >> >> When I once looked, I thought all drivers using NO_IRQ were specific >> to powerpc or one of the less common architectures. > >powerpc definitely does seem to be the biggest case, with about half >the instances of NO_IRQ being under arch/powerpc/ (and a few more in >ppc-specific drivers). > >Adding the powerpc maintainers to the list - because it would really >be nice to get rid of it, or at least make it *so* rare that we don't >have people re-introducing it again because they thought it was the >right thing to do. > >A fair amount of of it could even be done by some trivial scripting. >Something like > > git grep -wl NO_IRQ arch/powerpc/ | while read a > do > sed 's/(\([a-z_]*irq\) != NO_IRQ)/(\1)/' < $a > $a.new > sed 's/(\([a-z_]*irq\) == NO_IRQ)/(!\1)/' < $a.new > $a > done > >does fix at least a few of the cases. It still leaves several >assignments and "return NO_IRQ;" statements, but a few more >sed-scripts would take care of most of it. Then remove the #define, >and do a full build to find any straggling cases. > >Michael? Ben? Yeah sounds good. I'll do a patch on Monday and push it through the build farm. cheers -- Sent from my Android phone with K-9 Mail. Please excuse my brevity.