From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 01EA91B3D for ; Tue, 2 Jul 2019 21:34:02 +0000 (UTC) Received: from bedivere.hansenpartnership.com (bedivere.hansenpartnership.com [66.63.167.143]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id A00EA70D for ; Tue, 2 Jul 2019 21:34:01 +0000 (UTC) Message-ID: <1562103238.3321.66.camel@HansenPartnership.com> From: James Bottomley To: Kees Cook Date: Tue, 02 Jul 2019 14:33:58 -0700 In-Reply-To: <201907020926.FB19EDEBCC@keescook> References: <20263.1561993564@warthog.procyon.org.uk> <1561996215.3551.49.camel@HansenPartnership.com> <1562077203.3321.2.camel@HansenPartnership.com> <1562080257.3321.19.camel@HansenPartnership.com> <1562080696.3321.21.camel@HansenPartnership.com> <37eb32f3-f341-b1d8-293b-c119ae278b4f@linuxfoundation.org> <1562082713.3321.38.camel@HansenPartnership.com> <201907020926.FB19EDEBCC@keescook> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Cc: ksummit-discuss@lists.linuxfoundation.org Subject: Re: [Ksummit-discuss] [MAINTAINERS SUMMIT] Patch version changes in commit logs? List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, 2019-07-02 at 09:30 -0700, Kees Cook wrote: > On Tue, Jul 02, 2019 at 08:51:53AM -0700, James Bottomley wrote: > > Yes, I think we all agree on this. The real question is how. If > > we make git do it, I think trivially Message-Id: can become part of > > the optional metadata. Or we could all use commit hooks that add a > > link tag. Personally I prefer the former because it would be > > universally done with no effort but I recognise it would take time > > to get the ecosystem change to propagate. > > I think this should be easy to implement in a general way. I suspect > there wouldn't be much love for hard-coding the details, though, so > maybe it would require per-developer git configuration. I imagine a > general mapping would need to be: > > list_email -> archive_url > > i.e. if "$list_email" is in the To/Cc, then "git am" can easily > insert the Message-Id into the "$archive_url". For example: > > linux-kernel@vger.kernel.org -> https://lkml.kernel.org/r/%s I don't want to admit to being the sucker who actually looking into coding this today, so shall we just say I learned through "contacts" that git already has this feature: --- commit a078f7321b02eb945b63804a80b0ba52c9da4ed3 Author: Paolo Bonzini Date: Tue Nov 25 15:00:56 2014 +0100 git-am: add --message-id/--no-message-id --- It's not quite as we would wish: it adds a Message-ID: Tag to the commit. For some reason its undocumented, but it's been there since version 2.3.0. I realise the format isn't what we've been discussing, but if it's there we can use it ... and since it's in a pretty early version we can all use it now. James