From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 66EE48A5 for ; Mon, 1 Aug 2016 13:41:35 +0000 (UTC) Received: from galahad.ideasonboard.com (galahad.ideasonboard.com [185.26.127.97]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id E72732AE for ; Mon, 1 Aug 2016 13:41:34 +0000 (UTC) From: Laurent Pinchart To: ksummit-discuss@lists.linuxfoundation.org Date: Mon, 01 Aug 2016 16:41:34 +0300 Message-ID: <1491859.MaHxabKd3d@avalon> In-Reply-To: <20160729174035.5967f2bf@gandalf.local.home> References: <20160729210739.GI1494@piout.net> <20160729174035.5967f2bf@gandalf.local.home> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: James Bottomley , Trond Myklebust Subject: Re: [Ksummit-discuss] [CORE TOPIC] stable workflow List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Hi Steven, On Friday 29 Jul 2016 17:40:35 Steven Rostedt wrote: > On Fri, 29 Jul 2016 23:07:39 +0200 Alexandre Belloni wrote: > > Well, some tests depend on hardware availability but any hardware can > > work. I'm obviously thinking about RTCs. rtctest can run with any RTC. > > Also, one of my question here is whether kselftests could or couldn't be > > destructive. Running rtctest will currently overwrite the next alarm > > that may be set in an RTC. I was also planning to extend it in a way > > that will unfortunately also overwrite the current date and time. > > I'm not sure this is OK, especially for people that want to run those > > tests automatically. > > Anything that can cause harm to the system probably shouldn't be added > to kselftests. Unless there's a way you can record what the settings > were, and reset them after the test. Agreed. If we could standardize the test framework enough to make out-of-tree tests possible, the kselftest unit tests and the out-of-tree tests could implement the same interface and be handled by the same test runners. kselftest could then be a standard library of core tests maintained in the kernel, with additional tests available from different locations. -- Regards, Laurent Pinchart