From: Joe Perches <joe@perches.com>
To: Greg KH <greg@kroah.com>
Cc: ksummit-discuss@lists.linux-foundation.org,
ksummit-discuss@lists.linuxfoundation.org
Subject: Re: [Ksummit-discuss] [CORE TOPIC] checkpatch/Codingstyle and trivial patch spam
Date: Wed, 14 Sep 2016 07:23:48 -0700 [thread overview]
Message-ID: <1473863028.32273.28.camel@perches.com> (raw)
In-Reply-To: <20160914115456.GB22341@kroah.com>
On Wed, 2016-09-14 at 13:54 +0200, Greg KH wrote:
> On Tue, Sep 13, 2016 at 07:24:22PM -0700, Joe Perches wrote:
> > On Tue, 2016-09-13 at 19:03 -0700, Josh Triplett wrote:
> > > "Do
> > > not mass-reformat existing code, even if it doesn't follow these
> > > guidelines; doing so creates noise in version control history and makes
> > > patches fail to apply."
> > Or maybe add something like a new entry for what types of changes
> > are acceptable with a default of "none"
> > C: Whitespace and Style
> Ick, no, we have way too many things in the MAINTAINERS file as it is...
So what would use propose instead?
I think the primary issue is people using "scripts/checkpatch.pl -f"
I think that shouldn't be done without an understanding of when
it is useful and when it is not useful to use that -f option.
I have proposed adding an undocumented --force option to checkpatch
which would disallow -f unless --force is also used.
https://lkml.org/lkml/2015/2/11/433
Does anyone object to this?
next prev parent reply other threads:[~2016-09-14 14:23 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-13 18:58 Christian Borntraeger
2016-09-13 19:18 ` Joe Perches
2016-09-13 19:45 ` Josh Triplett
2016-09-13 20:03 ` Jonathan Corbet
2016-09-13 22:14 ` Joe Perches
2016-09-14 5:29 ` Julia Lawall
2016-09-13 23:49 ` Rafael J. Wysocki
2016-09-14 2:03 ` Josh Triplett
2016-09-14 2:24 ` Joe Perches
2016-09-14 5:57 ` Julia Lawall
2016-09-14 6:27 ` Joe Perches
2016-09-14 6:35 ` Julia Lawall
2016-09-14 6:43 ` Joe Perches
2016-09-14 17:11 ` Alexandre Belloni
2016-09-15 16:33 ` Jonathan Cameron
2016-09-14 11:54 ` Greg KH
2016-09-14 14:23 ` Joe Perches [this message]
2016-09-14 14:32 ` Greg KH
2016-09-14 14:35 ` Julia Lawall
2016-09-14 14:39 ` Theodore Ts'o
2016-09-14 19:26 ` Julia Lawall
2016-09-14 14:51 ` Joe Perches
2016-09-14 19:30 ` Julia Lawall
2016-09-14 14:51 ` Joe Perches
2016-09-14 14:45 ` Guenter Roeck
2016-09-14 15:13 ` Joe Perches
2016-09-14 19:46 ` Guenter Roeck
2016-09-14 18:04 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1473863028.32273.28.camel@perches.com \
--to=joe@perches.com \
--cc=greg@kroah.com \
--cc=ksummit-discuss@lists.linux-foundation.org \
--cc=ksummit-discuss@lists.linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox