From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id C8BF5902 for ; Fri, 2 Sep 2016 22:34:55 +0000 (UTC) Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 2A2E8F5 for ; Fri, 2 Sep 2016 22:34:53 +0000 (UTC) Message-ID: <1472854611.2313.5.camel@kernel.crashing.org> From: Benjamin Herrenschmidt To: Linus Torvalds , Arnd Bergmann , Michael Ellerman Date: Sat, 03 Sep 2016 08:16:51 +1000 In-Reply-To: References: <20160902104619.GD9355@localhost> <7359509.5sppVSLXcK@wuerfel> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Cc: ksummit-discuss@lists.linuxfoundation.org, "Nikula, Jani" , Dave Airlie , Grant Likely , ppc-dev Subject: Re: [Ksummit-discuss] [CORE TOPIC] (group) maintainership models List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Fri, 2016-09-02 at 13:26 -0700, Linus Torvalds wrote: > On Fri, Sep 2, 2016 at 1:06 PM, Arnd Bergmann wrote: > > > > > > When I once looked, I thought all drivers using NO_IRQ were > > specific > > to powerpc or one of the less common architectures. We deprecated NO_IRQ ages ago, it's 0 like it should be, but yes we may have forgotten to "cleanup" the old users.   > powerpc definitely does seem to be the biggest case, with about half > the instances of NO_IRQ being under arch/powerpc/ (and a few more in > ppc-specific drivers). > > Adding the powerpc maintainers to the list - because it would really > be nice to get rid of it, or at least make it *so* rare that we don't > have people re-introducing it again because they thought it was the > right thing to do. Right. Originally it was -1 for us which causes the whole problem. I changed it to be 0 after doing the whole irq domain remapping thing. That was a loooong time ago. > A fair amount of of it could even be done by some trivial scripting. > Something like > >   git grep -wl NO_IRQ arch/powerpc/ | while read a >   do >       sed 's/(\([a-z_]*irq\) != NO_IRQ)/(\1)/' < $a > $a.new >       sed 's/(\([a-z_]*irq\) == NO_IRQ)/(!\1)/' < $a.new > $a >   done > > does fix at least a few of the cases. It still leaves several > assignments and "return NO_IRQ;" statements, but a few more > sed-scripts would take care of most of it. Then remove the #define, > and do a full build to find any straggling cases. > > Michael? Ben? It can just be replaced with "0" in all powerpc related cases yes. Cheers, Ben.