On Tue, 2016-07-26 at 06:44 -0700, Guenter Roeck wrote: > > > We really should have more of an expectation that new code should be > > submitted *with* test cases. After all, it's not like people are > > generally submitting code that's *entirely* untested. It's more that > > testing is ad-hoc, and sometimes depends on running on specific > > hardware. But even the latter can often be fixed, with appropriate test > > harnesses. > > > > Worthy goal, but knowing developers I am quite concerned that it would result > in (possibly much) less kernel contributions. In addition to contributions > from unaffiliated individuals, there is a lot of code in vendor trees which > is not upstreamed today. Demanding test cases for upstreaming would for sure > make the interest in upstreaming that code even lower than it is today. Sure, but I did say an *expectation* rather than a hard requirement. We are nothing if not pragmatic. Having the *infrastructure* in place, and plenty of existing examples, would make this a whole lot easier for submitters. And also might be a good proving ground for people who would otherwise be doing precisely the kind of 'trivial' patches which are often problematic... -- David Woodhouse Open Source Technology Centre David.Woodhouse@intel.com Intel Corporation