From: David Woodhouse <dwmw2@infradead.org>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: ksummit-discuss@lists.linux-foundation.org,
Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [Ksummit-discuss] No more module removal -- Unconference track
Date: Tue, 19 Aug 2014 12:23:11 -0500 [thread overview]
Message-ID: <1408468991.29765.140.camel@shinybook.infradead.org> (raw)
In-Reply-To: <CACxGe6tsFM13t5VTYb9GaD4iEz_Bb6GtfXJP0nS-ocziPSbLHg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 920 bytes --]
On Tue, 2014-08-19 at 12:13 -0500, Grant Likely wrote:
> On Tue, Aug 19, 2014 at 11:43 AM, David Woodhouse <dwmw2@infradead.org> wrote:
> > On Tue, 2014-08-19 at 08:47 -0700, Guenter Roeck wrote:
> >>
> >> If you want to taint the kernel on module removal because it is known that many
> >> drivers have bugs in their removal code,
> >
> > Most drivers don't have "removal code" per se. They have "unbind" code.
> > Which you can still exercise without actually unloading the driver.
>
> Many platform, i2c, spi drivers have moved to macro generated module
> removal code that does nothing but unregister the struct
> device_driver.
That's exactly what I mean. There is no interesting code for unloading
the module. There is only the code for unbinding the device from the
driver (as in hot-unplug). Which doesn't go away if you disable module
unloading. It just gets harder to test.
--
dwmw2
[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 5745 bytes --]
next prev parent reply other threads:[~2014-08-19 17:23 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-19 14:48 Theodore Ts'o
2014-08-19 14:55 ` Guenter Roeck
2014-08-19 15:23 ` Theodore Ts'o
2014-08-19 15:40 ` Dan Carpenter
2014-08-19 15:47 ` Guenter Roeck
2014-08-19 16:09 ` Dan Carpenter
2014-08-19 16:34 ` Martin K. Petersen
2014-08-19 16:59 ` Rik van Riel
2014-08-19 17:19 ` Guenter Roeck
2014-08-19 16:43 ` David Woodhouse
2014-08-19 17:13 ` Grant Likely
2014-08-19 17:23 ` David Woodhouse [this message]
2014-08-19 15:54 ` Takashi Iwai
2014-08-25 11:01 ` Masami Hiramatsu
2014-08-25 11:05 ` Jiri Kosina
2014-08-26 5:24 ` Masami Hiramatsu
2014-08-27 23:05 ` Theodore Ts'o
2014-08-26 21:39 ` David Howells
2014-08-26 21:45 ` Jiri Kosina
2014-08-27 6:43 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1408468991.29765.140.camel@shinybook.infradead.org \
--to=dwmw2@infradead.org \
--cc=dan.carpenter@oracle.com \
--cc=grant.likely@secretlab.ca \
--cc=ksummit-discuss@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox