Re: [Ksummit-discuss] [TOPIC] Encouraging more reviewers

[Mimi Zohar <zohar@linux.vnet.ibm.com>]

On Wed, 2014-05-28 at 17:39 +0100, Mark Brown wrote: 
> On Wed, May 28, 2014 at 04:39:15PM +0200, Daniel Vetter wrote:
> 
> > My approach has been to insist on an in-patch revision log which gets
> > included in the commit. And that for any changes and bugs spotted the
> > reviewer/commenter must be acknowleged. See e.g.
> > d978ef14456a38034f6c0e for a very nice example of that. But that's
> > also a good example for no tag to acknowledge all the work that went
> > into this review/patch, since I've done the final review myself and
> > only put my sob onto the patch.
> 
> This does mean that the final changelogs that get included in the kernel
> get very large and noisy and is relying on the submitters doing a good
> job paying attention to review comments in the first place, recording
> exactly what changed and so on.  They are sometimes useful but normally
> I'm finding very little value in the changelogs in the first place,
> generally it doesn't really matter what the problems were in any
> previous versions.

True, but when you have to squash patches there needs to be at least
some recognition of who contributed what.

Mimi